From: Zhi Wang <zhi.a.wang@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Cowperthwaite, David J" <david.j.cowperthwaite@intel.com>,
"igvt-g@lists.01.org" <igvt-g@lists.01.org>,
"Lv, Zhiyuan" <zhiyuan.lv@intel.com>
Subject: Re: [RFCv3 10/15] drm/i915: update PDPs by condition when submit the LRC context
Date: Wed, 16 Mar 2016 14:32:26 +0800 [thread overview]
Message-ID: <56E8FDFA.7000801@intel.com> (raw)
In-Reply-To: <F3B0350DF4CB6849A642218320DE483D4B906F15@SHSMSX101.ccr.corp.intel.com>
Hi Chris:
Your idea is good. :) We could emit PDP upgrade LRIs like i915
before emit GVT worload under GVT context, then we can reuse the
pd_dirty_ring bitmap.
But I have to expose intel_logical_ring_emit_pdps() function for GVT-g.
Is it acceptable?
Thanks,
Zhi.
On 03/11/16 20:56, Wang, Zhi A wrote:
> OK. I will see. :) Thanks for the comments.
>
> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Friday, March 11, 2016 7:28 PM
> To: Wang, Zhi A
> Cc: intel-gfx@lists.freedesktop.org; igvt-g@lists.01.org; Tian, Kevin; Lv, Zhiyuan; Niu, Bing; Song, Jike; daniel.vetter@ffwll.ch; Cowperthwaite, David J; joonas.lahtinen@linux.intel.com
> Subject: Re: [RFCv3 10/15] drm/i915: update PDPs by condition when submit the LRC context
>
> On Fri, Mar 11, 2016 at 06:59:41PM +0800, Zhi Wang wrote:
>> Previously the PDPs inside the ring context will be updated
>>
>> - When populating a LRC context
>> - Before submitting a LRC context (only for 32 bit PPGTT, as the amount
>> of used PDPs may be changed during PPGTT page table grow)
>>
>> Under GVT-g, each VM owns a GVT context used as the shadow context. When
>> guest submits a context, GVT-g will load guest context into the GVT
>> context, and submit this context to i915 GEM submission system.
>>
>> So this GVT context could be used by different guest context, and the
>> PPGTT root pointer in guest contexts might be different as well, if guest
>> is using full PPGTT mode.
>>
>> In current i915, the root pointer in a LRC context will only be updated
>> during the LRC context creation.
>>
>> This patch postpones the root pointer upgrade to the time of submission,
>> which will give GVT-g a chance to reload a new PPGTT page table root
>> pointer into an existing GVT context.
>
> Not explained is why you cannot use the existing dirty flags.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-16 6:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 10:59 [RFCv3 00/15] Introduce GVT context support Zhi Wang
2016-03-11 10:59 ` [RFCv3 01/15] drm/i915: factor out i915_pvinfo.h Zhi Wang
2016-03-11 10:59 ` [RFCv3 02/15] drm/i915/gvt: Introduce the basic architecture of GVT-g Zhi Wang
2016-03-11 10:59 ` [RFCv3 03/15] drm/i915: Introduce host graphics memory partition for GVT-g Zhi Wang
2016-03-11 10:59 ` [RFCv3 04/15] drm/i915: factor out alloc_context_idr() and __i915_gem_create_context() Zhi Wang
2016-03-11 10:59 ` [RFCv3 05/15] drm/i915: factor out __create_legacy_hw_context() Zhi Wang
2016-03-11 10:59 ` [RFCv3 06/15] drm/i915: let __i915_gem_context_create() takes context creation params Zhi Wang
2016-03-11 10:59 ` [RFCv3 07/15] drm/i915: factor out __intel_lr_context_deferred_alloc() Zhi Wang
2016-03-11 10:59 ` [RFCv3 08/15] drm/i915: Support per-PPGTT address space mode Zhi Wang
2016-03-11 10:59 ` [RFCv3 09/15] drm/i915: generate address mode bit from PPGTT instance Zhi Wang
2016-03-11 10:59 ` [RFCv3 10/15] drm/i915: update PDPs by condition when submit the LRC context Zhi Wang
2016-03-11 11:27 ` Chris Wilson
2016-03-11 12:56 ` Wang, Zhi A
2016-03-16 6:32 ` Zhi Wang [this message]
2016-03-11 10:59 ` [RFCv3 11/15] drm/i915: Introduce execlist context status change notification Zhi Wang
2016-03-11 11:28 ` Chris Wilson
2016-03-11 12:47 ` Wang, Zhi A
2016-03-11 10:59 ` [RFCv3 12/15] drm/i915: Support context single submission Zhi Wang
2016-03-11 11:25 ` Chris Wilson
2016-03-11 12:42 ` Wang, Zhi A
2016-03-11 10:59 ` [RFCv3 13/15] drm/i915: Introduce GVT context creation API Zhi Wang
2016-03-11 10:59 ` [RFCv3 14/15] drm/i915: factor out and expose i915_steal_fence() Zhi Wang
2016-03-11 11:21 ` Chris Wilson
2016-03-11 12:29 ` Wang, Zhi A
2016-03-11 12:42 ` Chris Wilson
2016-03-11 12:53 ` Wang, Zhi A
2016-03-11 12:55 ` Wang, Zhi A
2016-03-11 10:59 ` [RFCv3 15/15] drm/i915: expose i915_find_fence_reg() Zhi Wang
2016-03-11 11:09 ` ✗ Fi.CI.BAT: failure for Introduce GVT context support Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E8FDFA.7000801@intel.com \
--to=zhi.a.wang@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=david.j.cowperthwaite@intel.com \
--cc=igvt-g@lists.01.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.