From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] clk: sunxi: Remove use of VLAIS To: Stephen Boyd , Maxime Ripard Cc: Chen-Yu Tsai , Michael Turquette , linux-clk References: <20160226194830.GA21652@lukather> <1456878048-23393-1-git-send-email-sboyd@codeaurora.org> <20160303191604.GW24999@codeaurora.org> <20160304152711.GR8418@lukather> <20160304171841.GF24999@codeaurora.org> <20160308221320.GI8418@lukather> <20160315221601.GJ25972@codeaurora.org> From: Mason Message-ID: <56E91EA4.7030603@free.fr> Date: Wed, 16 Mar 2016 09:51:48 +0100 MIME-Version: 1.0 In-Reply-To: <20160315221601.GJ25972@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 List-ID: On 15/03/2016 23:16, Stephen Boyd wrote: > On 03/08, Maxime Ripard wrote: > >> On Fri, Mar 04, 2016 at 09:18:41AM -0800, Stephen Boyd wrote: >> >>> Oh right. Let's hope third time is the last. >>> >>> ---8<--- >>> From: Stephen Boyd >>> Subject: [PATCH] clk: sunxi: Remove use of variable length array >>> >>> Using an array allocated on the stack may lead to stack overflows >>> and other problems so let's move the allocation to the heap >>> instead. This silences the following checker warning as well. >>> >>> drivers/clk/sunxi/clk-sun8i-mbus.c:36:29: warning: Variable length array is used. >>> >>> Cc: Chen-Yu Tsai >>> Cc: Maxime Ripard >>> Signed-off-by: Stephen Boyd >> >> Acked-by: Maxime Ripard >> > > Applied to clk-next. For the record, I will state again that I find it quite sub-optimal to resort to dynamic allocation for small temporary pointer arrays. A fortiori when one considers that getting the patch right required several attempts. Regards.