From: Samuel Pitoiset <samuel.pitoiset@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>, Ilia Mirkin <imirkin@alum.mit.edu>
Cc: mesa-dev@lists.freedesktop.org, nouveau@lists.freedesktop.org
Subject: Re: [PATCH mesa v2 1/3] tgsi: Fix decl.Atomic and .Shared not propagating when parsing tgsi text
Date: Wed, 16 Mar 2016 10:40:13 +0100 [thread overview]
Message-ID: <56E929FD.9020309@gmail.com> (raw)
In-Reply-To: <1458118502-9016-1-git-send-email-hdegoede@redhat.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
On 03/16/2016 09:55 AM, Hans de Goede wrote:
> When support for decl.Atomic and .Shared was added, tgsi_build_declaration
> was not updated to propagate these properly.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
> ---
> Changes in v2:
> -Add Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
> ---
> src/gallium/auxiliary/tgsi/tgsi_build.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_build.c b/src/gallium/auxiliary/tgsi/tgsi_build.c
> index e5355f5..1cb95b9 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_build.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_build.c
> @@ -127,6 +127,8 @@ tgsi_build_declaration(
> unsigned invariant,
> unsigned local,
> unsigned array,
> + unsigned atomic,
> + unsigned shared,
> struct tgsi_header *header )
> {
> struct tgsi_declaration declaration;
> @@ -143,6 +145,8 @@ tgsi_build_declaration(
> declaration.Invariant = invariant;
> declaration.Local = local;
> declaration.Array = array;
> + declaration.Atomic = atomic;
> + declaration.Shared = shared;
> header_bodysize_grow( header );
>
> return declaration;
> @@ -401,6 +405,8 @@ tgsi_build_full_declaration(
> full_decl->Declaration.Invariant,
> full_decl->Declaration.Local,
> full_decl->Declaration.Array,
> + full_decl->Declaration.Atomic,
> + full_decl->Declaration.Shared,
> header );
>
> if (maxsize <= size)
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
prev parent reply other threads:[~2016-03-16 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 8:55 [PATCH mesa v2 1/3] tgsi: Fix decl.Atomic and .Shared not propagating when parsing tgsi text Hans de Goede
[not found] ` <1458118502-9016-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-16 8:55 ` [PATCH mesa v2 2/3] tgsi: Add support for global / private / input MEMORY Hans de Goede
[not found] ` <1458118502-9016-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-16 9:47 ` Samuel Pitoiset
2016-03-16 8:55 ` [PATCH mesa v2 3/3] nouveau: codegen: Add support for clover / OpenCL kernel input parameters Hans de Goede
[not found] ` <1458118502-9016-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-16 9:49 ` Samuel Pitoiset
2016-03-16 9:40 ` Samuel Pitoiset [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E929FD.9020309@gmail.com \
--to=samuel.pitoiset@gmail.com \
--cc=hdegoede@redhat.com \
--cc=imirkin@alum.mit.edu \
--cc=mesa-dev@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.