From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: DRM framebuffer removal broken since 13803132
Date: Wed, 16 Mar 2016 11:17:22 +0100 [thread overview]
Message-ID: <56E932B2.9040203@linux.intel.com> (raw)
In-Reply-To: <56E91A98.4040303@vmware.com>
Hey,
Op 16-03-16 om 09:34 schreef Thomas Hellstrom:
> Hi!
>
> The commit
>
> From 13803132818cf8084d169617be060fd8e3411a98 Mon Sep 17 00:00:00 2001
> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Date: Wed, 9 Sep 2015 16:40:56 +0200
> Subject: [PATCH] drm/core: Preserve the framebuffer after removing it.
>
> badly breaks vmwgfx multimon since the crtcs are no longer turned off at
> framebuffer removal,
> which is part of the user-space contract.
Is this about rmfb or lastclose?
Lastclose is handled by kms fbdev emulation, rmfb behavioral change was intentional, but can be reverted.
> Also isn't this a security issue, since at, for example, Xorg crash, the
> crtcs can be left scanning out from memory
> DRM no longer owns?
>
Not in general, the drivers I've worked with have the framebuffers holding a reference to the underlying
object storage. Else this would be a security issue without the rmfb behavior too.
~Maarten
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-16 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 8:34 DRM framebuffer removal broken since 13803132 Thomas Hellstrom
2016-03-16 10:17 ` Maarten Lankhorst [this message]
2016-03-16 10:21 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E932B2.9040203@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.