All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Dimitris Aragiorgis <dimara@arrikto.com>
Subject: Re: [Qemu-devel] [PATCH 3/9] log: improve code in do_qemu_set_log
Date: Wed, 16 Mar 2016 12:25:10 +0100	[thread overview]
Message-ID: <56E94296.9070003@redhat.com> (raw)
In-Reply-To: <56E9418E.7080105@openvz.org>



On 16/03/2016 12:20, Denis V. Lunev wrote:
> The question here is the following actually.
> 
> Should we continue to keep writing 'stderr' output to the log file
> when we have cleared all log levels. If the answer is 'yes',
> original == your code is correct while my is wrong. In the
> other case - the situation becomes mirrored.

You're right about the actual question to answer.

I think the answer is yes, given the original purpose of Dimitris's
patch.  The behavior of "-daemonize -D foo" should be the same if QEMU
is configured with or without the "log" trace backend.

Paolo

  reply	other threads:[~2016-03-16 11:25 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 11:21 [Qemu-devel] [PATCH v2 0/9] log: assorted improvements Denis V. Lunev
2016-03-14 11:21 ` [Qemu-devel] [PATCH 1/9] trace: do not always call exit() in trace_enable_events Denis V. Lunev
2016-03-14 14:25   ` Paolo Bonzini
2016-03-14 11:21 ` [Qemu-devel] [PATCH 2/9] qemu-log: fix cpu_reset log target Denis V. Lunev
2016-03-14 14:24   ` Paolo Bonzini
2016-03-14 11:21 ` [Qemu-devel] [PATCH 3/9] log: improve code in do_qemu_set_log Denis V. Lunev
2016-03-14 14:28   ` Paolo Bonzini
2016-03-16 11:20     ` Denis V. Lunev
2016-03-16 11:25       ` Paolo Bonzini [this message]
2016-03-14 11:21 ` [Qemu-devel] [PATCH 4/9] log: move qemu_log_close/qemu_log_flush from header to log.c Denis V. Lunev
2016-03-14 14:29   ` Paolo Bonzini
2016-03-14 11:21 ` [Qemu-devel] [PATCH 5/9] log: improve performance of qemu_log and qemu_log_mask if disabled Denis V. Lunev
2016-03-14 14:30   ` Paolo Bonzini
2016-03-14 15:07     ` Denis V. Lunev
2016-03-14 11:21 ` [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies Denis V. Lunev
2016-03-14 14:33   ` Paolo Bonzini
2016-03-14 14:38     ` Daniel P. Berrange
2016-03-14 15:00       ` Denis V. Lunev
2016-03-14 15:05       ` Denis V. Lunev
2016-03-14 15:26         ` Daniel P. Berrange
2016-03-14 16:10           ` Denis V. Lunev
2016-03-14 16:37             ` Paolo Bonzini
2016-03-14 16:11           ` Daniel P. Berrange
2016-03-14 16:16             ` Denis V. Lunev
2016-03-14 16:40               ` Paolo Bonzini
2016-03-16 13:09                 ` Denis V. Lunev
2016-03-16 13:11                   ` Paolo Bonzini
2016-03-17 15:31                     ` Daniel P. Berrange
2016-03-14 11:21 ` [Qemu-devel] [PATCH 7/9] log: report HMP command and event Denis V. Lunev
2016-03-14 14:36   ` Paolo Bonzini
2016-03-14 15:08     ` Denis V. Lunev
2016-03-14 16:35       ` Paolo Bonzini
2016-03-14 11:21 ` [Qemu-devel] [PATCH 8/9] log: report QAPI event Denis V. Lunev
2016-03-14 14:33   ` Paolo Bonzini
2016-03-14 11:21 ` [Qemu-devel] [PATCH 9/9] log: adds a timestamp to each log entry Denis V. Lunev
2016-03-14 14:39   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E94296.9070003@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=den@openvz.org \
    --cc=dimara@arrikto.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.