From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755137AbcCPLkv (ORCPT ); Wed, 16 Mar 2016 07:40:51 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54084 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754841AbcCPLku (ORCPT ); Wed, 16 Mar 2016 07:40:50 -0400 Subject: Re: [PATCH] regulator: Don't print error in devm_regulator_bulk_get() on -EPROBE_DEFER To: Mark Brown References: <1458074114-8088-1-git-send-email-javier@osg.samsung.com> <20160316095946.GR2566@sirena.org.uk> <56E9414E.3030609@osg.samsung.com> <20160316113715.GV2566@sirena.org.uk> Cc: linux-kernel@vger.kernel.org, Liam Girdwood From: Javier Martinez Canillas Message-ID: <56E9463B.9080106@osg.samsung.com> Date: Wed, 16 Mar 2016 08:40:43 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160316113715.GV2566@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, On 03/16/2016 08:37 AM, Mark Brown wrote: > On Wed, Mar 16, 2016 at 08:19:42AM -0300, Javier Martinez Canillas wrote: [snip] > >> Basically I want to get rid of things like this: > >> [ 1.438422] exynos-hdmi 14530000.hdmi: Failed to get supply 'vdd': -517 >> [ 1.443638] [drm:hdmi_probe] *ERROR* failed to get regulators >> [ 1.449326] [drm:hdmi_probe] *ERROR* hdmi_resources_init failed > >> The HDMI driver probed correctly but looking at the log it seems that things >> failed so can mislead users not familiar with the probe deferral mechanism. > > So fix probe deferral. Don't go through the entire kernel hacking in > bodges everywhere, if we have to hack the error handling for almost all > resource acquisition errors during probe that's obviously not sensible. > Got it, thanks a lot for your explanations. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America