From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 3/3] drm/radeon: uvd/vce properly pin/unpin firmware accross suspend/resume. Date: Wed, 16 Mar 2016 13:10:35 +0100 Message-ID: <56E94D3B.5020800@amd.com> References: <1458129407-4940-1-git-send-email-jglisse@redhat.com> <1458129407-4940-3-git-send-email-jglisse@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0062.outbound.protection.outlook.com [157.56.110.62]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9C226E179 for ; Wed, 16 Mar 2016 12:10:54 +0000 (UTC) In-Reply-To: <1458129407-4940-3-git-send-email-jglisse@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jglisse@redhat.com, dri-devel@lists.freedesktop.org Cc: Alex Deucher List-Id: dri-devel@lists.freedesktop.org QW0gMTYuMDMuMjAxNiB1bSAxMjo1NiBzY2hyaWViIGpnbGlzc2VAcmVkaGF0LmNvbToKPiBGcm9t OiBKw6lyb21lIEdsaXNzZSA8amdsaXNzZUByZWRoYXQuY29tPgo+Cj4gV2UgbmVlZCB0byB1bnBp biBvbiBzdXNwZW5kIGFuZCBwaW4gb24gcmVzdW1lLiBUaGlzIHNodWZmbGUgY29kZSBhcm91bmQK PiB0byBkbyBqdXN0IHRoYXQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKw6lyw7RtZSBHbGlzc2UgPGpn bGlzc2VAcmVkaGF0LmNvbT4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBh bWQuY29tPgo+IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+ CgpOQUssIHRoYXQgd29uJ3Qgd29yayBjb3JyZWN0bHkuCgpXaGVuIHRoZSBmaXJtd2FyZSBpcyBs b2FkZWQgYXQgb25lIGxvY2F0aW9uIG9uY2UgeW91IGNhbid0IG1vdmUgaXQgCndpdGhvdXQgcG93 ZXIgY3ljbGluZyB0aGUgQVNJQy4KClRoYXQgb25seSB3b3JrcyB3aGVuIHlvdSBjb21wbGV0ZWx5 IHNodXQgZG93biB0aGUgc3lzdGVtLCBidXQgbm90IGlmIHlvdSAKanVzdCBzdXNwZW5kIHRvIG1l bW9yeSBvbiBhbiBBUFUgb3IgZG8gYSB0ZXN0IGN5Y2xlIHdpdGhvdXQgYWN0dWFsbHkgCnBvd2Vy IGRvd24uCgpXZSBhbHJlYWR5IHRyaWVkIHRoaXMgYXBwcm9hY2ggYW5kIGl0IHRvb2sgbWUgbW9u dGggdG8gZmlndXJlIG91dCB3aGF0J3MgCmdvaW5nIHdyb25nIHdoZW4gdGhlIGZpcm13YXJlIGVu ZCB1cCBhdCBhIGRpZmZlcmVudCBsb2NhdGlvbiBhZnRlciB0aGUgCmRyaXZlciBzdGFydGVkIGFn YWluLgoKUmVnYXJkcywKQ2hyaXN0aWFuLgoKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9yYWRl b24vcmFkZW9uX3V2ZC5jIHwgNjEgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t LQo+ICAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fdmNlLmMgfCAzNyArKysrKysrKyst LS0tLS0tLS0tLS0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDU3IGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9u X3V2ZC5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fdXZkLmMKPiBpbmRleCA2ZmU5 ZTRlLi4zMzNiODg1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9u X3V2ZC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fdXZkLmMKPiBAQCAt MTQ4LDMwICsxNDgsNiBAQCBpbnQgcmFkZW9uX3V2ZF9pbml0KHN0cnVjdCByYWRlb25fZGV2aWNl ICpyZGV2KQo+ICAgCQlyZXR1cm4gcjsKPiAgIAl9Cj4gICAKPiAtCXIgPSByYWRlb25fYm9fcmVz ZXJ2ZShyZGV2LT51dmQudmNwdV9ibywgZmFsc2UpOwo+IC0JaWYgKHIpIHsKPiAtCQlyYWRlb25f Ym9fdW5yZWYoJnJkZXYtPnV2ZC52Y3B1X2JvKTsKPiAtCQlkZXZfZXJyKHJkZXYtPmRldiwgIigl ZCkgZmFpbGVkIHRvIHJlc2VydmUgVVZEIGJvXG4iLCByKTsKPiAtCQlyZXR1cm4gcjsKPiAtCX0K PiAtCj4gLQlyID0gcmFkZW9uX2JvX3BpbihyZGV2LT51dmQudmNwdV9ibywgUkFERU9OX0dFTV9E T01BSU5fVlJBTSwKPiAtCQkJICAmcmRldi0+dXZkLmdwdV9hZGRyKTsKPiAtCWlmIChyKSB7Cj4g LQkJcmFkZW9uX2JvX3VucmVzZXJ2ZShyZGV2LT51dmQudmNwdV9ibyk7Cj4gLQkJcmFkZW9uX2Jv X3VucmVmKCZyZGV2LT51dmQudmNwdV9ibyk7Cj4gLQkJZGV2X2VycihyZGV2LT5kZXYsICIoJWQp IFVWRCBibyBwaW4gZmFpbGVkXG4iLCByKTsKPiAtCQlyZXR1cm4gcjsKPiAtCX0KPiAtCj4gLQly ID0gcmFkZW9uX2JvX2ttYXAocmRldi0+dXZkLnZjcHVfYm8sICZyZGV2LT51dmQuY3B1X2FkZHIp Owo+IC0JaWYgKHIpIHsKPiAtCQlkZXZfZXJyKHJkZXYtPmRldiwgIiglZCkgVVZEIG1hcCBmYWls ZWRcbiIsIHIpOwo+IC0JCXJldHVybiByOwo+IC0JfQo+IC0KPiAtCXJhZGVvbl9ib191bnJlc2Vy dmUocmRldi0+dXZkLnZjcHVfYm8pOwo+IC0KPiAgIAlmb3IgKGkgPSAwOyBpIDwgUkFERU9OX01B WF9VVkRfSEFORExFUzsgKytpKSB7Cj4gICAJCWF0b21pY19zZXQoJnJkZXYtPnV2ZC5oYW5kbGVz W2ldLCAwKTsKPiAgIAkJcmRldi0+dXZkLmZpbHBbaV0gPSBOVUxMOwo+IEBAIC0xODMsMTggKzE1 OSw5IEBAIGludCByYWRlb25fdXZkX2luaXQoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4g ICAKPiAgIHZvaWQgcmFkZW9uX3V2ZF9maW5pKHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2KQo+ ICAgewo+IC0JaW50IHI7Cj4gLQo+ICAgCWlmIChyZGV2LT51dmQudmNwdV9ibyA9PSBOVUxMKQo+ ICAgCQlyZXR1cm47Cj4gICAKPiAtCXIgPSByYWRlb25fYm9fcmVzZXJ2ZShyZGV2LT51dmQudmNw dV9ibywgZmFsc2UpOwo+IC0JaWYgKCFyKSB7Cj4gLQkJcmFkZW9uX2JvX2t1bm1hcChyZGV2LT51 dmQudmNwdV9ibyk7Cj4gLQkJcmFkZW9uX2JvX3VucGluKHJkZXYtPnV2ZC52Y3B1X2JvKTsKPiAt CQlyYWRlb25fYm9fdW5yZXNlcnZlKHJkZXYtPnV2ZC52Y3B1X2JvKTsKPiAtCX0KPiAtCj4gICAJ cmFkZW9uX2JvX3VucmVmKCZyZGV2LT51dmQudmNwdV9ibyk7Cj4gICAKPiAgIAlyYWRlb25fcmlu Z19maW5pKHJkZXYsICZyZGV2LT5yaW5nW1I2MDBfUklOR19UWVBFX1VWRF9JTkRFWF0pOwo+IEBA IC0yMzEsNiArMTk4LDEzIEBAIGludCByYWRlb25fdXZkX3N1c3BlbmQoc3RydWN0IHJhZGVvbl9k ZXZpY2UgKnJkZXYpCj4gICAJCX0KPiAgIAl9Cj4gICAKPiArCXIgPSByYWRlb25fYm9fcmVzZXJ2 ZShyZGV2LT51dmQudmNwdV9ibywgZmFsc2UpOwo+ICsJaWYgKCFyKSB7Cj4gKwkJcmFkZW9uX2Jv X2t1bm1hcChyZGV2LT51dmQudmNwdV9ibyk7Cj4gKwkJcmFkZW9uX2JvX3VucGluKHJkZXYtPnV2 ZC52Y3B1X2JvKTsKPiArCQlyYWRlb25fYm9fdW5yZXNlcnZlKHJkZXYtPnV2ZC52Y3B1X2JvKTsK PiArCX0KPiArCj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiBAQCAtMjM4LDkgKzIxMiwyNiBA QCBpbnQgcmFkZW9uX3V2ZF9yZXN1bWUoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4gICB7 Cj4gICAJdW5zaWduZWQgc2l6ZTsKPiAgIAl2b2lkICpwdHI7Cj4gKwlpbnQgcjsKPiAgIAo+IC0J aWYgKHJkZXYtPnV2ZC52Y3B1X2JvID09IE5VTEwpCj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwly ID0gcmFkZW9uX2JvX3Jlc2VydmUocmRldi0+dXZkLnZjcHVfYm8sIGZhbHNlKTsKPiArCWlmIChy KSB7Cj4gKwkJZGV2X2VycihyZGV2LT5kZXYsICIoJWQpIGZhaWxlZCB0byByZXNlcnZlIFVWRCBi b1xuIiwgcik7Cj4gKwkJcmV0dXJuIHI7Cj4gKwl9Cj4gKwlyID0gcmFkZW9uX2JvX3BpbihyZGV2 LT51dmQudmNwdV9ibywgUkFERU9OX0dFTV9ET01BSU5fVlJBTSwKPiArCQkJICAmcmRldi0+dXZk LmdwdV9hZGRyKTsKPiArCWlmIChyKSB7Cj4gKwkJcmFkZW9uX2JvX3VucmVzZXJ2ZShyZGV2LT51 dmQudmNwdV9ibyk7Cj4gKwkJZGV2X2VycihyZGV2LT5kZXYsICIoJWQpIFVWRCBibyBwaW4gZmFp bGVkXG4iLCByKTsKPiArCQlyZXR1cm4gcjsKPiArCX0KPiArCXIgPSByYWRlb25fYm9fa21hcChy ZGV2LT51dmQudmNwdV9ibywgJnJkZXYtPnV2ZC5jcHVfYWRkcik7Cj4gKwlyYWRlb25fYm9fdW5y ZXNlcnZlKHJkZXYtPnV2ZC52Y3B1X2JvKTsKPiArCWlmIChyKSB7Cj4gKwkJZGV2X2VycihyZGV2 LT5kZXYsICIoJWQpIFVWRCBtYXAgZmFpbGVkXG4iLCByKTsKPiArCQlyZXR1cm4gcjsKPiArCX0K PiAgIAo+ICAgCW1lbWNweShyZGV2LT51dmQuY3B1X2FkZHIsIHJkZXYtPnV2ZF9mdy0+ZGF0YSwg cmRldi0+dXZkX2Z3LT5zaXplKTsKPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v cmFkZW9uL3JhZGVvbl92Y2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX3ZjZS5j Cj4gaW5kZXggYzFjNjE5Zi4uNGY3YWUzYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v cmFkZW9uL3JhZGVvbl92Y2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9u X3ZjZS5jCj4gQEAgLTE0NywyMiArMTQ3LDYgQEAgaW50IHJhZGVvbl92Y2VfaW5pdChzdHJ1Y3Qg cmFkZW9uX2RldmljZSAqcmRldikKPiAgIAkJcmV0dXJuIHI7Cj4gICAJfQo+ICAgCj4gLQlyID0g cmFkZW9uX2JvX3Jlc2VydmUocmRldi0+dmNlLnZjcHVfYm8sIGZhbHNlKTsKPiAtCWlmIChyKSB7 Cj4gLQkJcmFkZW9uX2JvX3VucmVmKCZyZGV2LT52Y2UudmNwdV9ibyk7Cj4gLQkJZGV2X2Vycihy ZGV2LT5kZXYsICIoJWQpIGZhaWxlZCB0byByZXNlcnZlIFZDRSBib1xuIiwgcik7Cj4gLQkJcmV0 dXJuIHI7Cj4gLQl9Cj4gLQo+IC0JciA9IHJhZGVvbl9ib19waW4ocmRldi0+dmNlLnZjcHVfYm8s IFJBREVPTl9HRU1fRE9NQUlOX1ZSQU0sCj4gLQkJCSAgJnJkZXYtPnZjZS5ncHVfYWRkcik7Cj4g LQlyYWRlb25fYm9fdW5yZXNlcnZlKHJkZXYtPnZjZS52Y3B1X2JvKTsKPiAtCWlmIChyKSB7Cj4g LQkJcmFkZW9uX2JvX3VucmVmKCZyZGV2LT52Y2UudmNwdV9ibyk7Cj4gLQkJZGV2X2VycihyZGV2 LT5kZXYsICIoJWQpIFZDRSBibyBwaW4gZmFpbGVkXG4iLCByKTsKPiAtCQlyZXR1cm4gcjsKPiAt CX0KPiAtCj4gICAJZm9yIChpID0gMDsgaSA8IFJBREVPTl9NQVhfVkNFX0hBTkRMRVM7ICsraSkg ewo+ICAgCQlhdG9taWNfc2V0KCZyZGV2LT52Y2UuaGFuZGxlc1tpXSwgMCk7Cj4gICAJCXJkZXYt PnZjZS5maWxwW2ldID0gTlVMTDsKPiBAQCAtMTk2LDcgKzE4MCw3IEBAIHZvaWQgcmFkZW9uX3Zj ZV9maW5pKHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2KQo+ICAgICovCj4gICBpbnQgcmFkZW9u X3ZjZV9zdXNwZW5kKHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2KQo+ICAgewo+IC0JaW50IGk7 Cj4gKwlpbnQgaSwgcjsKPiAgIAo+ICAgCWlmIChyZGV2LT52Y2UudmNwdV9ibyA9PSBOVUxMKQo+ ICAgCQlyZXR1cm4gMDsKPiBAQCAtMjA5LDYgKzE5MywxMyBAQCBpbnQgcmFkZW9uX3ZjZV9zdXNw ZW5kKHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2KQo+ICAgCQlyZXR1cm4gMDsKPiAgIAo+ICAg CS8qIFRPRE86IHN1c3BlbmRpbmcgcnVubmluZyBlbmNvZGluZyBzZXNzaW9ucyBpc24ndCBzdXBw b3J0ZWQgKi8KPiArCj4gKwlyID0gcmFkZW9uX2JvX3Jlc2VydmUocmRldi0+dmNlLnZjcHVfYm8s IGZhbHNlKTsKPiArCWlmICghcikgewo+ICsJCXJhZGVvbl9ib191bnBpbihyZGV2LT52Y2UudmNw dV9ibyk7Cj4gKwkJcmFkZW9uX2JvX3VucmVzZXJ2ZShyZGV2LT52Y2UudmNwdV9ibyk7Cj4gKwl9 Cj4gKwo+ICAgCXJldHVybiAtRUlOVkFMOwo+ICAgfQo+ICAgCj4gQEAgLTIyMywxNSArMjE0LDE4 IEBAIGludCByYWRlb25fdmNlX3Jlc3VtZShzdHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRldikKPiAg IAl2b2lkICpjcHVfYWRkcjsKPiAgIAlpbnQgcjsKPiAgIAo+IC0JaWYgKHJkZXYtPnZjZS52Y3B1 X2JvID09IE5VTEwpCj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQo+ICAgCXIgPSByYWRlb25fYm9f cmVzZXJ2ZShyZGV2LT52Y2UudmNwdV9ibywgZmFsc2UpOwo+ICAgCWlmIChyKSB7Cj4gICAJCWRl dl9lcnIocmRldi0+ZGV2LCAiKCVkKSBmYWlsZWQgdG8gcmVzZXJ2ZSBWQ0UgYm9cbiIsIHIpOwo+ ICAgCQlyZXR1cm4gcjsKPiAgIAl9Cj4gLQo+ICsJciA9IHJhZGVvbl9ib19waW4ocmRldi0+dmNl LnZjcHVfYm8sIFJBREVPTl9HRU1fRE9NQUlOX1ZSQU0sCj4gKwkJCSAgJnJkZXYtPnZjZS5ncHVf YWRkcik7Cj4gKwlpZiAocikgewo+ICsJCXJhZGVvbl9ib191bnJlc2VydmUocmRldi0+dmNlLnZj cHVfYm8pOwo+ICsJCWRldl9lcnIocmRldi0+ZGV2LCAiKCVkKSBWQ0UgYm8gcGluIGZhaWxlZFxu Iiwgcik7Cj4gKwkJcmV0dXJuIHI7Cj4gKwl9Cj4gICAJciA9IHJhZGVvbl9ib19rbWFwKHJkZXYt PnZjZS52Y3B1X2JvLCAmY3B1X2FkZHIpOwo+ICAgCWlmIChyKSB7Cj4gICAJCXJhZGVvbl9ib191 bnJlc2VydmUocmRldi0+dmNlLnZjcHVfYm8pOwo+IEBAIC0yNDYsNyArMjQwLDYgQEAgaW50IHJh ZGVvbl92Y2VfcmVzdW1lKHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2KQo+ICAgCQltZW1jcHko Y3B1X2FkZHIsIHJkZXYtPnZjZV9mdy0+ZGF0YSwgcmRldi0+dmNlX2Z3LT5zaXplKTsKPiAgIAo+ ICAgCXJhZGVvbl9ib19rdW5tYXAocmRldi0+dmNlLnZjcHVfYm8pOwo+IC0KPiAgIAlyYWRlb25f Ym9fdW5yZXNlcnZlKHJkZXYtPnZjZS52Y3B1X2JvKTsKPiAgIAo+ICAgCXJldHVybiByOwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==