From mboxrd@z Thu Jan  1 00:00:00 1970
From: Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH v2 3/3] tmem: allow tmem to be disabled with
	Kconfig
Date: Wed, 16 Mar 2016 07:54:55 -0500
Message-ID: <56E9579F.4090702@cardoe.com>
References: <1458073130-5126-1-git-send-email-cardoe@cardoe.com>
 <1458073130-5126-4-git-send-email-cardoe@cardoe.com>
 <56E92B9F02000078000DCF69@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3263487720483246151=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56E92B9F02000078000DCF69@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============3263487720483246151==
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="QdpitJ4dgo3RO7avPxXgGGgaJxE21on3L"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--QdpitJ4dgo3RO7avPxXgGGgaJxE21on3L
Content-Type: multipart/mixed; boundary="kLl0DPNCOxwehPA9CioHF1ErgodxDxx58"
From: Doug Goldstein <cardoe@cardoe.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Keir Fraser <keir@xen.org>
Message-ID: <56E9579F.4090702@cardoe.com>
Subject: Re: [PATCH v2 3/3] tmem: allow tmem to be disabled with Kconfig
References: <1458073130-5126-1-git-send-email-cardoe@cardoe.com>
 <1458073130-5126-4-git-send-email-cardoe@cardoe.com>
 <56E92B9F02000078000DCF69@prv-mh.provo.novell.com>
In-Reply-To: <56E92B9F02000078000DCF69@prv-mh.provo.novell.com>

--kLl0DPNCOxwehPA9CioHF1ErgodxDxx58
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 3/16/16 3:47 AM, Jan Beulich wrote:
>>>> On 15.03.16 at 21:18, <cardoe@cardoe.com> wrote:
>> Wrap the various tmem functions with the Kconfig generated CONFIG_TMEM=

>> option allowing users to build Xen without tmem support.
>>
>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>> ---
>> CC: Keir Fraser <keir@xen.org>
>> CC: Jan Beulich <jbeulich@suse.com>
>> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>
>> changes from v1:
>> - add description provided by Konrad (thanks!)
>> - tweaks to Makefile suggested by Jan
>=20
> Only kind of:
>=20
>> @@ -65,7 +63,12 @@ obj-bin-$(CONFIG_X86) +=3D $(foreach n,decompress b=
unzip2 unxz unlzma unlzo unlz4
>>  obj-$(perfc)       +=3D perfc.o
>>  obj-$(crash_debug) +=3D gdbstub.o
>> =20
>> -obj-$(CONFIG_COMPAT) +=3D $(addprefix compat/,domain.o kernel.o memor=
y.o multicall.o tmem_xen.o xlat.o)
>> +obj-$(CONFIG_COMPAT) +=3D $(addprefix compat/,domain.o kernel.o memor=
y.o multicall.o xlat.o)
>> +
>> +tmem-y +=3D tmem.o
>> +tmem-y +=3D tmem_xen.o
>=20
> I had intentionally suggested
>=20
> tmem-y :=3D tmem.o tmem_xen.o
>=20
> Splitting this up into two lines is a matter of taste, but not using :=3D=
 is
> inefficient, as it requires make to possibly expand the variable many
> times instead of just once.
>=20
> But anyway - since functionality wise this is fine, with or without tha=
t
> further adjustment
> Acked-by: Jan Beulich <jbeulich@suse.com>
>=20
> Jan
>=20

You're right. Its worth correcting. I'll post a v3. Can I retain your
Acked-by?

--=20
Doug Goldstein


--kLl0DPNCOxwehPA9CioHF1ErgodxDxx58--

--QdpitJ4dgo3RO7avPxXgGGgaJxE21on3L
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0

iQJ8BAEBCgBmBQJW6VeiXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB
MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU8ywQAJGoNh+7hbW9Di9cQjtDdg+w
UlDPtRFmlnC61lwUKG8jm3uDmJyL47JDoiBpOoLDHWyxS9boKRcYkLoEJm4HaDgZ
VoBmp8zuHBOSyd9doPIeGgkMzfZaZhvPTWvDajdgm0l5vejlmTfVt03t8NGOCh5x
tKK7QLAxtdvKU0B3t8JYn+vkdI6g3+VnlVpca1F3b/dQmIqVpQRDUFuTOL/Z/Duz
tSkVT5usoMTbha+lfGBHWIWw+1louy+CoKcDJ1/zzL6jz9Doz3TkgK66at2IuEvX
77kkN2ZlkVgWCRSBRWWxOWStiWskxXzxYVx+fcZyXVfxkn47BJ6wCPn8x3VMAfF1
LpTw0OIuMoDfLWgm6whMdHHT0SanHoTQfEwDhekD7FwpENKkB98/cONwiZFywFHH
lHgsxGjwvRx7FZfyHp/NtSxZ91bcO8xTHVVLt+A+iqzANowUlGxQb08QbbkaCWE0
RiplMGpWT4TRN9ypdUX55Tvyp9uVT1+ct3/NaWKUWZbcuPeGdReX8G6hYuYxWAf6
Pa4y2aHa8eM5MENFruUhlVDrO4vWDnrFX4Rz9x2dx0Bt6mjdeMw6EMNf+6myd+kZ
8ppeI6m6s9HrwOBEkk5TpFcWgJVFrSOhCtCms4Muy4bzkxIUfryz97gc9s5AOLKQ
b1Lbq3hMOYuKEhTGNd4M
=3Fvx
-----END PGP SIGNATURE-----

--QdpitJ4dgo3RO7avPxXgGGgaJxE21on3L--


--===============3263487720483246151==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============3263487720483246151==--