From: Steve Dickson <SteveD@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsidmapd: allow the usage message to be displayed
Date: Wed, 16 Mar 2016 10:46:45 -0400 [thread overview]
Message-ID: <56E971D5.5010205@RedHat.com> (raw)
In-Reply-To: <1455368071-15198-1-git-send-email-steved@redhat.com>
On 02/13/2016 07:54 AM, Steve Dickson wrote:
> xlog_err() never returns. Change the xlog_err(),
> when invalid arguments are use, to xlog_warn()
> so the second xlog_warn, displaying the usage,
> will be called.
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...
steved.
> ---
> utils/nfsidmap/nfsidmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/nfsidmap/nfsidmap.c b/utils/nfsidmap/nfsidmap.c
> index d980c68..2abefe9 100644
> --- a/utils/nfsidmap/nfsidmap.c
> +++ b/utils/nfsidmap/nfsidmap.c
> @@ -430,7 +430,7 @@ int main(int argc, char **argv)
>
> xlog_stderr(verbose);
> if ((argc - optind) != 2) {
> - xlog_err("Bad arg count. Check /etc/request-key.conf");
> + xlog_warn("Bad arg count. Check /etc/request-key.conf");
> xlog_warn(usage, progname);
> return EXIT_FAILURE;
> }
>
prev parent reply other threads:[~2016-03-16 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 12:54 [PATCH] nfsidmapd: allow the usage message to be displayed Steve Dickson
2016-03-16 14:46 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E971D5.5010205@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.