Re: [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

[Doug Goldstein <cardoe@cardoe.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1542 bytes --]

On 3/14/16 9:05 AM, Doug Goldstein wrote:
> On 3/8/16 12:01 PM, Daniel De Graaf wrote:
>> On 03/08/2016 11:51 AM, Jan Beulich wrote:
>>>>>> On 08.03.16 at 17:22, <dgdegra@tycho.nsa.gov> wrote:
>>>> On 03/08/2016 04:46 AM, Jan Beulich wrote:
>>>>>>>> On 07.03.16 at 19:42, <cardoe@cardoe.com> wrote:
>>>>>> Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with
>>>>>> CONFIG_
>>>>>> to use the Kconfig variable.
>>>>>
>>>>> Same question here: What's the benefit of doing it this way?
>>>>
>>>> This removes the stats tracking, which might (I have not tested)
>>>> speed up
>>>> the security server by avoiding the __get_cpu_var call and increment.
>>>
>>> No, I don not think the patch removes anything. The Kconfig option
>>> doesn't have a prompt. But anyway, ...
>>
>> Ah, I missed that: I saw the --help-- line and assumed it was the prompt.
>> Either way, this #define is a configuration-like knob that doesn't need to
>> be hard-coded in a header as it currently is.
>>
>>>
>>>> The
>>>> corresponding SELinux knob is a Kconfig option in Linux.
>>>>
>>>> Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
>>>
>>> ... if you're fine with it, we'll put it in (once the mechanical issues
>>> got addressed).
>>
> 
> Daniel,
> 
> Would you like me to make this a real configuration option? Or proceed
> with the current path and we can make a configuration option later?
> 

I'll resubmit as is and we can address making that a user facing option
in a follow on.

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel