From: Paolo Bonzini <pbonzini@redhat.com>
To: xiaoqiang zhao <zxq_yx_007@163.com>, qemu-devel@nongnu.org
Cc: michael@walle.cc, kraxel@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c
Date: Wed, 16 Mar 2016 17:30:08 +0100 [thread overview]
Message-ID: <56E98A10.6070809@redhat.com> (raw)
In-Reply-To: <1458120244-30976-5-git-send-email-zxq_yx_007@163.com>
On 16/03/2016 10:24, xiaoqiang zhao wrote:
> s->voice_out = AUD_open_out(&s->card, s->voice_out,
> "mm_ac97.out", s, ac97_out_cb, &as);
>
AUD_open_out should not be done before realize.
Paolo
next prev parent reply other threads:[~2016-03-16 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 9:24 [Qemu-devel] [PATCH 0/4] QOM'ify hw/audio files xiaoqiang zhao
2016-03-16 9:24 ` [Qemu-devel] [PATCH 1/4] hw/audio: QOM'ify cs4231.c xiaoqiang zhao
2016-03-16 16:30 ` Paolo Bonzini
2016-03-16 9:24 ` [Qemu-devel] [PATCH 2/4] hw/audio: QOM cleanup for intel-hda xiaoqiang zhao
2016-03-16 9:24 ` [Qemu-devel] [PATCH 3/4] hw/audio: QOM'ify intel-hda xiaoqiang zhao
2016-03-16 9:24 ` [Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c xiaoqiang zhao
2016-03-16 16:30 ` Paolo Bonzini [this message]
2016-03-17 1:39 ` xiaoqiang zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E98A10.6070809@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=michael@walle.cc \
--cc=qemu-devel@nongnu.org \
--cc=zxq_yx_007@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.