From: Peter Hurley <peter@hurleysoftware.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Russell King <rmk@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Jonathan Corbet <corbet@lwn.net>,
linux-serial@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 6/9] serial: doc: .break_ctl() is called with port->mutex() held
Date: Wed, 16 Mar 2016 09:46:12 -0700 [thread overview]
Message-ID: <56E98DD4.3030302@hurleysoftware.com> (raw)
In-Reply-To: <1457968577-22379-7-git-send-email-geert+renesas@glider.be>
On 03/14/2016 08:16 AM, Geert Uytterhoeven wrote:
> Note that mutex_lock() should not be called with interrupts disabled.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/serial/driver | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/serial/driver b/Documentation/serial/driver
> index 3b08df5bcc17e944..09e73e061fcf795c 100644
> --- a/Documentation/serial/driver
> +++ b/Documentation/serial/driver
> @@ -177,8 +177,7 @@ hardware.
> should be terminated when another call is made with a zero
> ctl.
>
> - Locking: none.
> - Interrupts: caller dependent.
> + Locking: caller holds port->mutex
> This call must not sleep
^^^^^^^
And remove this line as well.
>
> startup(port)
>
next prev parent reply other threads:[~2016-03-16 16:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 15:16 [PATCH 0/9] serial: doc: Low Level Serial API Documentation Improvements Geert Uytterhoeven
2016-03-14 15:16 ` [PATCH 1/9] serial: doc: Un-document non-existing uart_write_console() Geert Uytterhoeven
2016-03-16 16:01 ` Peter Hurley
2016-03-16 16:17 ` Geert Uytterhoeven
2016-03-14 15:16 ` [PATCH 2/9] serial: doc: Un-document obsolete tmpbuf_sem Geert Uytterhoeven
2016-03-16 16:02 ` Peter Hurley
2016-03-14 15:16 ` [PATCH 3/9] serial: doc: Document .throttle() Geert Uytterhoeven
2016-03-16 16:19 ` Geert Uytterhoeven
2016-03-16 16:39 ` Peter Hurley
2016-03-14 15:16 ` [PATCH 4/9] serial: doc: Document .unthrottle() Geert Uytterhoeven
2016-03-14 15:16 ` [PATCH 5/9] serial: doc: Document .set_ldisc() Geert Uytterhoeven
2016-03-16 16:49 ` Peter Hurley
2016-03-14 15:16 ` [PATCH 6/9] serial: doc: .break_ctl() is called with port->mutex() held Geert Uytterhoeven
2016-03-16 16:46 ` Peter Hurley [this message]
2016-03-14 15:16 ` [PATCH 7/9] serial: doc: Spelling s/divsor/divisor/ Geert Uytterhoeven
2016-03-14 15:16 ` [PATCH 8/9] serial: doc: Grammar s/function are/functions are/ Geert Uytterhoeven
2016-03-14 15:16 ` [PATCH 9/9] serial: doc: Correct return type of mctrl_gpio_to_gpiod() Geert Uytterhoeven
2016-03-31 6:59 ` [PATCH 0/9] serial: doc: Low Level Serial API Documentation Improvements Jonathan Corbet
2016-03-31 8:26 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E98DD4.3030302@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.