From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agFDi-0004Tn-Gq for qemu-devel@nongnu.org; Wed, 16 Mar 2016 13:26:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agFDf-0003gU-Aw for qemu-devel@nongnu.org; Wed, 16 Mar 2016 13:26:54 -0400 References: <1458134034-32500-1-git-send-email-clg@fr.ibm.com> <1458134034-32500-3-git-send-email-clg@fr.ibm.com> From: Thomas Huth Message-ID: <56E99756.8000901@redhat.com> Date: Wed, 16 Mar 2016 18:26:46 +0100 MIME-Version: 1.0 In-Reply-To: <1458134034-32500-3-git-send-email-clg@fr.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 02/10] ppc: Add macros to register hypervisor mode SPRs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 16.03.2016 14:13, C=C3=A9dric Le Goater wrote: > From: Benjamin Herrenschmidt >=20 > The current set of spr_register_* macros only take the user and > supervisor function pointers. To make the transition easy, we > don't change that but we add "_hv" variants that can be used to > register all 3 sets. >=20 > To simplify the transition, users of the "old" macro will set the > hypervisor callback to be the same as the supervisor one. The new > registration function only needs to be used for registers that are > either hypervisor only or behave differently in HV mode. >=20 > Signed-off-by: Benjamin Herrenschmidt > Reviewed-by: David Gibson > [clg: fixed else if condition in gen_op_mfspr() ] > Signed-off-by: C=C3=A9dric Le Goater > --- > target-ppc/translate.c | 26 ++++++++++++++++---------- > target-ppc/translate_init.c | 35 +++++++++++++++++++++++++++++++---- > 2 files changed, 47 insertions(+), 14 deletions(-) >=20 [...] Reviewed-by: Thomas Huth