From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agFUG-0000kE-RY for qemu-devel@nongnu.org; Wed, 16 Mar 2016 13:44:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agFUB-0000r7-Rj for qemu-devel@nongnu.org; Wed, 16 Mar 2016 13:44:00 -0400 References: <1458134034-32500-1-git-send-email-clg@fr.ibm.com> <1458134034-32500-8-git-send-email-clg@fr.ibm.com> From: Thomas Huth Message-ID: <56E99B57.2070305@redhat.com> Date: Wed, 16 Mar 2016 18:43:51 +0100 MIME-Version: 1.0 In-Reply-To: <1458134034-32500-8-git-send-email-clg@fr.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 16.03.2016 14:13, C=C3=A9dric Le Goater wrote: > From: Benjamin Herrenschmidt >=20 > The masks weren't chosen nor applied properly. The architecture specifi= es > that writes to AMR are masked by UAMOR for PR=3D1, otherwise AMOR for H= V=3D0. >=20 > The writes to UAMOR are masked by AMOR for HV=3D0 >=20 > Signed-off-by: Benjamin Herrenschmidt > [clg: moved gen_spr_amr() prototype change to next patch ] > Signed-off-by: C=C3=A9dric Le Goater > --- > target-ppc/translate_init.c | 74 ++++++++++++++++++++++++++++++++++++-= -------- > 1 file changed, 59 insertions(+), 15 deletions(-) Reviewed-by: Thomas Huth