All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] libexport.a: fix missing brace in host_ntop() fallback
Date: Wed, 16 Mar 2016 14:19:45 -0400	[thread overview]
Message-ID: <56E9A3C1.10500@RedHat.com> (raw)
In-Reply-To: <1455805236-30534-1-git-send-email-stefanha@redhat.com>



On 02/18/2016 09:20 AM, Stefan Hajnoczi wrote:
> An if statement has been missing a brace since host_ntop() was added in
> commit 94ce1eb94babb4c587b2826452fb053cba745098 ("libexport.a: Add
> helpers to manage DNS lookups").
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Committed... 

steved.

> ---
>  support/export/hostname.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/export/hostname.c b/support/export/hostname.c
> index 4daabe9..94e98a5 100644
> --- a/support/export/hostname.c
> +++ b/support/export/hostname.c
> @@ -69,7 +69,7 @@ host_ntop(const struct sockaddr *sap, char *buf, const size_t buflen)
>  
>  	memset(buf, 0, buflen);
>  
> -	if (sin->sin_family != AF_INET)
> +	if (sin->sin_family != AF_INET) {
>  		(void)strncpy(buf, "bad family", buflen - 1);
>  		return buf;
>  	}
> 

      reply	other threads:[~2016-03-16 18:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 14:20 [PATCH] libexport.a: fix missing brace in host_ntop() fallback Stefan Hajnoczi
2016-03-16 18:19 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E9A3C1.10500@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.