From: Mason <slash.tmp@free.fr>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] clk: sunxi: Remove use of VLAIS
Date: Wed, 16 Mar 2016 21:44:48 +0100 [thread overview]
Message-ID: <56E9C5C0.901@free.fr> (raw)
In-Reply-To: <20160316203018.GQ25972@codeaurora.org>
On 16/03/2016 21:30, Stephen Boyd wrote:
> On 03/16, Mason wrote:
>> On 15/03/2016 23:16, Stephen Boyd wrote:
>>>
>>> Applied to clk-next.
>>
>> For the record, I will state again that I find it quite sub-optimal
>> to resort to dynamic allocation for small temporary pointer arrays.
>>
>> A fortiori when one considers that getting the patch right required
>> several attempts.
>
> Feel free to send the patch and then we can discuss and test. For
> the record, I was waiting for Maxime or Chen-Yu to speak up if
> they would prefer that approach, but nothing happened. Usually
> patches spur discussions better than comments.
While I didn't provide a formal patch, I did outline the two
lines that needed to be changed (and it is obvious that the
behavior is strictly equivalent to the VLA solution, as long
as num_parents < 8).
I do agree with you that, considering the silence from the
driver's maintainers, they probably don't care which solution
is adopted.
I will remember to post an actual patch next time.
Regards.
next prev parent reply other threads:[~2016-03-16 20:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 19:48 [GIT PULL] arm: Allwinner clocks changes for 4.6 Maxime Ripard
2016-02-26 19:48 ` Maxime Ripard
2016-03-02 0:20 ` [PATCH] clk: sunxi: Remove use of VLAIS Stephen Boyd
2016-03-03 18:07 ` Chen-Yu Tsai
2016-03-03 19:16 ` Stephen Boyd
2016-03-04 15:27 ` Maxime Ripard
2016-03-04 17:18 ` Stephen Boyd
2016-03-08 22:13 ` Maxime Ripard
2016-03-15 22:16 ` Stephen Boyd
2016-03-16 8:51 ` Mason
2016-03-16 20:30 ` Stephen Boyd
2016-03-16 20:44 ` Mason [this message]
2016-03-18 17:47 ` Maxime Ripard
2016-03-08 12:26 ` Mason
2016-03-02 1:46 ` [GIT PULL] arm: Allwinner clocks changes for 4.6 Stephen Boyd
2016-03-02 1:46 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9C5C0.901@free.fr \
--to=slash.tmp@free.fr \
--cc=linux-clk@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.