From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 11/16] package/Makefile.in: adjust LDFLAGS for elf2flt
Date: Thu, 17 Mar 2016 00:48:23 +0100 [thread overview]
Message-ID: <56E9F0C7.1060009@mind.be> (raw)
In-Reply-To: <1458164602-16983-12-git-send-email-thomas.petazzoni@free-electrons.com>
On 03/16/16 22:43, Thomas Petazzoni wrote:
> So far, our LDFLAGS for the BR2_BINFMT_FLAT case were only used on
> Blackfin. However, passing -elf2flt in LDFLAGS is wrong. Indeed,
> LDFLAGS are not linker flags, but flags passed to the compiler when
> linking.
>
> If you pass -elf2flt to the compiler when linking, it is understood as
> "-e lf2flt", i.e "the entry point is named lf2flt", which isn't
> exactly the intention. We in fact need to pass -Wl,-elf2flt in LDFLAGS
> as well, so that the compiler passes -elf2flt down to the linker.
>
> For some reason, this option does not cause an issue with the Blackfin
> toolchain,
Probably because it isn't tested so much :-)
> but it does with either a Buildroot toolchain for Cortex-M
> or an OSELAS toolchain for Cortex-M. We have verified that passing
> -Wl,-elf2flt continues to work with the Blackfin toolchain.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> package/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index dd595e2..616bdd0 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -145,7 +145,7 @@ TARGET_CFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FL
> -Wl$(comma)-elf2flt)
> TARGET_CXXFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE),\
> -Wl$(comma)-elf2flt)
> -TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-elf2flt=-s$($(PKG)_FLAT_STACKSIZE),-elf2flt)
> +TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt)
> endif
>
> ifeq ($(BR2_BINFMT_FLAT_SHARED),y)
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-03-16 23:48 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 21:43 [Buildroot] [PATCH 00/16] ARM Cortex-M support Thomas Petazzoni
2016-03-16 21:43 ` [Buildroot] [PATCH 01/16] arch/arm: introduce and use BR2_ARM_CPU_ARMV7M Thomas Petazzoni
2016-03-16 22:29 ` Arnout Vandecappelle
2016-03-16 21:43 ` [Buildroot] [PATCH 02/16] arch/arm: Cortex-M3 provides only Thumb-2 Thomas Petazzoni
2016-03-16 22:43 ` Arnout Vandecappelle
2016-03-17 8:03 ` Thomas Petazzoni
2016-03-17 11:08 ` Peter Korsgaard
2016-03-17 13:06 ` Thomas Petazzoni
2016-03-17 20:36 ` Thomas Petazzoni
2016-03-17 22:34 ` Arnout Vandecappelle
2016-03-16 21:43 ` [Buildroot] [PATCH 03/16] arch/arm: add Cortex-M4 entry Thomas Petazzoni
2016-03-16 22:50 ` Arnout Vandecappelle
2016-03-16 21:43 ` [Buildroot] [PATCH 04/16] uclibc: Enable compile in thumb mode when selected Thomas Petazzoni
2016-03-16 23:01 ` Arnout Vandecappelle
2016-03-17 11:21 ` Peter Korsgaard
2016-03-17 13:10 ` Thomas Petazzoni
2016-03-17 21:25 ` Thomas Petazzoni
2016-03-17 21:44 ` Peter Korsgaard
2016-03-17 22:03 ` Thomas Petazzoni
2016-03-17 22:18 ` Peter Korsgaard
2016-03-16 21:43 ` [Buildroot] [PATCH 05/16] uclibc: disable DOPIC on ARM noMMU Thomas Petazzoni
2016-03-16 23:09 ` Arnout Vandecappelle
2016-03-17 8:06 ` Thomas Petazzoni
2016-03-17 10:32 ` Max Filippov
2016-03-17 11:00 ` Thomas Petazzoni
2016-03-17 11:39 ` Max Filippov
2016-03-16 21:43 ` [Buildroot] [PATCH 06/16] uclibc: NPTL thread implementation only available on MMU platforms Thomas Petazzoni
2016-03-16 23:11 ` Arnout Vandecappelle
2016-03-17 12:14 ` Peter Korsgaard
2016-03-17 13:11 ` Thomas Petazzoni
2016-03-17 19:45 ` Waldemar Brodkorb
2016-03-17 20:08 ` Peter Korsgaard
2016-03-16 21:43 ` [Buildroot] [PATCH 07/16] musl: build broken on Thumb, use ARM mode Thomas Petazzoni
2016-03-16 23:14 ` Arnout Vandecappelle
2016-03-17 8:10 ` Thomas Petazzoni
2016-03-16 21:43 ` [Buildroot] [PATCH 08/16] toolchain-buildroot: update glibc comment for noMMU Thomas Petazzoni
2016-03-16 23:18 ` Arnout Vandecappelle
2016-03-18 20:49 ` Thomas Petazzoni
2016-03-18 20:59 ` Peter Korsgaard
2016-03-18 21:33 ` Arnout Vandecappelle
2016-03-16 21:43 ` [Buildroot] [PATCH 09/16] toolchain-buildroot: don't show musl on noMMU platforms Thomas Petazzoni
2016-03-16 23:26 ` Arnout Vandecappelle
2016-03-18 20:51 ` Thomas Petazzoni
2016-03-18 21:42 ` Arnout Vandecappelle
2016-03-16 21:43 ` [Buildroot] [PATCH 10/16] arch/arm: add support for hard-float on Cortex-M4 Thomas Petazzoni
2016-03-16 23:45 ` Arnout Vandecappelle
2016-03-17 8:16 ` Thomas Petazzoni
2016-03-18 21:47 ` Arnout Vandecappelle
2016-03-18 22:29 ` Thomas Petazzoni
2016-03-16 21:43 ` [Buildroot] [PATCH 11/16] package/Makefile.in: adjust LDFLAGS for elf2flt Thomas Petazzoni
2016-03-16 23:48 ` Arnout Vandecappelle [this message]
2016-03-16 21:43 ` [Buildroot] [PATCH 12/16] elf2flt: use new upstream site and add ARM patch Thomas Petazzoni
2016-03-16 23:50 ` Arnout Vandecappelle
2016-03-17 8:18 ` Thomas Petazzoni
2016-03-17 18:53 ` Mike Frysinger
2016-03-17 19:41 ` Waldemar Brodkorb
2016-03-17 20:34 ` Thomas Petazzoni
2016-03-17 20:45 ` Mike Frysinger
2016-03-17 19:39 ` Waldemar Brodkorb
2016-03-16 21:43 ` [Buildroot] [PATCH 13/16] elf2flt: disable Werror to avoid build issues Thomas Petazzoni
2016-03-16 23:53 ` Arnout Vandecappelle
2016-03-17 8:18 ` Thomas Petazzoni
2016-03-17 1:40 ` Mike Frysinger
2016-03-17 8:19 ` Thomas Petazzoni
2016-03-17 18:57 ` Mike Frysinger
2016-03-16 21:43 ` [Buildroot] [PATCH 14/16] afboot-stm32: use the Buildroot toolchain Thomas Petazzoni
2016-03-16 21:43 ` [Buildroot] [PATCH 15/16] configs/stm32f429_disco: new configuration for STM32F429 Discovery board Thomas Petazzoni
2016-03-16 21:43 ` [Buildroot] [PATCH 16/16] configs/stm32f469_disco: new configuration for STM32F469 " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9F0C7.1060009@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.