From: Durham Goode <durham@fb.com>
To: <git@vger.kernel.org>
Cc: <pclouds@gmail.com>, Mateusz Kwapich <mitrandir@fb.com>
Subject: bug: sparse config interpretation incorrectness in 2.8.0-rc2
Date: Wed, 16 Mar 2016 17:09:23 -0700 [thread overview]
Message-ID: <56E9F5B3.6030903@fb.com> (raw)
Using git 2.8.0-rc2, given a repo with the following files:
- one/hideme
- one/donthide
- two/foo
A sparse config of:
cat > .git/info/sparse-checkout <<EOF
/*
!one/hideme
EOF
Results in a repository that only has `one/donthide` in it. I would
expect `two/foo`to be present as well. This worked in 2.6, and
bisecting it points to d589a67eceacd1cc171bbe94906ca7c9a0edd8c5 "dir.c:
don't exclude whole dir prematurely" (author cc'd).
The script I used to repro and for bisecting is pasted below:
#!/bin/bash
set -x
rm -rf sparse-test
GIT=git
$GIT init sparse-test
cd sparse-test
$GIT config --add core.sparsecheckout true
mkdir one two
touch one/hideme
touch one/donthide
touch two/foo
$GIT add .
$GIT commit -m "initial commit"
$GIT read-tree --reset -u HEAD
mkdir .git/info
cat > .git/info/sparse-checkout <<EOF
/*
!one/hideme
EOF
$GIT read-tree --reset -u HEAD
ls -R one two
set +x
echo
echo expected: see one/donthide and two/foo
echo actual: see only one/donthide
[ -d two ] && exit 0
exit 1
next reply other threads:[~2016-03-17 0:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 0:09 Durham Goode [this message]
2016-03-17 0:56 ` bug: sparse config interpretation incorrectness in 2.8.0-rc2 Duy Nguyen
2016-03-17 6:49 ` Durham Goode
2016-03-17 7:51 ` Junio C Hamano
2016-03-17 10:17 ` Duy Nguyen
2016-03-17 13:04 ` Johannes Schindelin
2016-03-17 13:20 ` Duy Nguyen
2016-03-17 13:46 ` Johannes Schindelin
2016-03-17 14:00 ` Duy Nguyen
2016-03-18 15:49 ` Johannes Schindelin
2016-03-17 7:22 ` Junio C Hamano
2016-03-17 17:51 ` Durham Goode
2016-03-17 12:45 ` [PATCH 1/2] dir.c: fix bug in 'nd/exclusion-regression-fix' topic Nguyễn Thái Ngọc Duy
2016-03-17 12:45 ` Nguyễn Thái Ngọc Duy
2016-03-17 12:54 ` [PATCH 3/2] dir.c: fix dir re-inclusion rules with "NODIR" and "MUSTBEDIR" Nguyễn Thái Ngọc Duy
2016-03-17 23:49 ` Junio C Hamano
2016-03-18 0:15 ` Duy Nguyen
2016-03-18 5:40 ` Junio C Hamano
2016-03-18 5:51 ` Duy Nguyen
2016-03-18 5:58 ` Eric Sunshine
2016-03-18 4:51 ` Durham Goode
2016-03-18 5:40 ` Duy Nguyen
2016-03-18 6:21 ` Durham Goode
2016-03-18 6:28 ` Duy Nguyen
2016-03-18 18:00 ` Junio C Hamano
2016-03-18 18:37 ` Extending this cycle by a week and reverting !reinclusion topic Junio C Hamano
2016-03-19 1:03 ` [PATCH 3/2] dir.c: fix dir re-inclusion rules with "NODIR" and "MUSTBEDIR" Duy Nguyen
2016-03-17 12:45 ` [PATCH 2/2] dir.c: correct "stuck" logging logic Nguyễn Thái Ngọc Duy
2016-03-17 12:45 ` Nguyễn Thái Ngọc Duy
2016-03-18 17:38 ` [PATCH 1/2] dir.c: fix bug in 'nd/exclusion-regression-fix' topic Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9F5B3.6030903@fb.com \
--to=durham@fb.com \
--cc=git@vger.kernel.org \
--cc=mitrandir@fb.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.