From: Guenter Roeck <linux@roeck-us.net>
To: rcochran@linutronix.de, Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, rt@linutronix.de
Subject: Re: watchdog: octeon: missing FROZEN hot plug notifier actions
Date: Wed, 16 Mar 2016 20:18:22 -0700 [thread overview]
Message-ID: <56EA21FE.6040009@roeck-us.net> (raw)
In-Reply-To: <20160316205105.GA14847@linutronix.de>
On 03/16/2016 01:51 PM, rcochran@linutronix.de wrote:
>
> In drivers/watchdog/octeon-wdt-main.c, the hot plug notifier callback,
> octeon_wdt_cpu_callback, does not handle events with CPU_TASKS_FROZEN
> set in the action code.
>
> Is this on purpose? If so, then why is it done that way?
>
What do you expect it to do ?
My understanding is that CPU_TASKS_FROZEN is related to suspend/resume operations,
which are not really common for typical applications using Octeon CPUs. If they now
are, it might be worthwhile thinking about adding suspend/resume support to the driver.
Thanks,
Guenter
next prev parent reply other threads:[~2016-03-17 3:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 20:51 watchdog: octeon: missing FROZEN hot plug notifier actions rcochran
2016-03-17 3:18 ` Guenter Roeck [this message]
2016-03-17 8:08 ` rcochran
2016-03-17 13:04 ` Guenter Roeck
2016-03-17 13:51 ` rcochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EA21FE.6040009@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=rcochran@linutronix.de \
--cc=rt@linutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.