From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] docs: update FLASK cmd line instructions Date: Wed, 16 Mar 2016 23:32:24 -0500 Message-ID: <56EA3358.5060607@cardoe.com> References: <1458002259-22081-1-git-send-email-cardoe@cardoe.com> <20160315202427.GI26955@char.us.oracle.com> <56E87333.9080402@cardoe.com> <20160315204352.GK26955@char.us.oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8046291450436696475==" Return-path: In-Reply-To: <20160315204352.GK26955@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk Cc: Keir Fraser , Ian Jackson , Tim Deegan , xen-devel@lists.xen.org, Jan Beulich , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============8046291450436696475== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GVku4NflTQVFtWKQ8fFINdaugJ7PfVgv9" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GVku4NflTQVFtWKQ8fFINdaugJ7PfVgv9 Content-Type: multipart/mixed; boundary="A6c4unoBXrkPgVWIQG8NUdUpvWc6IApFn" From: Doug Goldstein To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xen.org, Ian Jackson , Jan Beulich , Keir Fraser , Tim Deegan , Daniel De Graaf Message-ID: <56EA3358.5060607@cardoe.com> Subject: Re: [PATCH] docs: update FLASK cmd line instructions References: <1458002259-22081-1-git-send-email-cardoe@cardoe.com> <20160315202427.GI26955@char.us.oracle.com> <56E87333.9080402@cardoe.com> <20160315204352.GK26955@char.us.oracle.com> In-Reply-To: <20160315204352.GK26955@char.us.oracle.com> --A6c4unoBXrkPgVWIQG8NUdUpvWc6IApFn Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/15/16 3:43 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 15, 2016 at 03:40:19PM -0500, Doug Goldstein wrote: >> On 3/15/16 3:24 PM, Konrad Rzeszutek Wilk wrote: >>> On Mon, Mar 14, 2016 at 07:37:39PM -0500, Doug Goldstein wrote: >>>> The command line instructions for FLASK include a note on how to com= pile >>>> Xen with FLASK but the note was out of date after the change to Kcon= fig. >>>> >>>> Signed-off-by: Doug Goldstein >>>> --- >>>> CC: Ian Jackson >>>> CC: Jan Beulich >>>> CC: Keir Fraser >>>> CC: Tim Deegan >>>> CC: Konrad Rzeszutek Wilk >>>> CC: Daniel De Graaf >>>> >>>> Not sure if you want backticks around `make -C menuconfig`. I also f= igured >>>> we should route people towards menuconfig by default. The committer = of >>>> this patch is welcome to change the wording or style in anyway they = see >>>> fit. >>>> >>>> --- >>>> docs/misc/xen-command-line.markdown | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-com= mand-line.markdown >>>> index ca77e3b..949e210 100644 >>>> --- a/docs/misc/xen-command-line.markdown >>>> +++ b/docs/misc/xen-command-line.markdown >>>> @@ -665,8 +665,8 @@ to use the default. >>>> > Default: `permissive` >>>> =20 >>>> Specify how the FLASK security server should be configured. This o= ption is only >>>> -available if the hypervisor was compiled with XSM support (which ca= n be enabled >>>> -by setting XSM\_ENABLE =3D y in .config). >>>> +available if the hypervisor was compiled with FLASK support. This = can be >>>> +enabled by running make -C xen menuconfig and enabling XSM and FLAS= K. >>> >>> Would it be better said: >>> >>> .. "and enabling Common Features|Xen Security Module support (FLux Ad= vanced Security >>> Kernel support gets enabled automatically)." >>> ? >> >> My response falls in the bucket of a tristate boolean. It depends on h= ow >> you want to document these values. By the pretty strings or the >> searchable names. And then making sure all the doc places are consiste= nt >> with that. >=20 > That was more of what I saw - when I tried 'make -C xen menuconfig' I d= idn't > see XSM or FLASK (I am being anal here, but the point is that newbies m= ay > need crystal clear explanations). > Perhaps both? >=20 >=20 > enabled by running: > * make -C xen menuconfig and enabling Common.... blahblah > * make -C xen oldconfig and enabling XSM and FLASK >=20 > ? >> >> --=20 >> Doug Goldstein >> >=20 >=20 >=20 I waited to see if some others wanted weigh in because this is the first of quite a few places in the docs that will need to be updated as I touch the remaining items in Rules.mk and wanted to make sure that however I things were documented they remained consistent. I'll take silence to mean acceptance and update this patch accordingly. Thanks for your help Konrad! --=20 Doug Goldstein --A6c4unoBXrkPgVWIQG8NUdUpvWc6IApFn-- --GVku4NflTQVFtWKQ8fFINdaugJ7PfVgv9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW6jNbXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU4WoP/2oJ6Cq09U/LZI8XexTRpEU2 NEqF+Ab5YMnrmsKXDHOJo6FMlloBi16FVQJYFelSdbN08oMbsddfFYknk36qUVOZ DAKk0THhqu+9/zrvjLyhWkLc8/a8sVvf8ZsBWHDgzg1S4VN5skh5cFW9aUBL6gcx xpEkrWjX8lbJbsN0xK+EN49VWnPbXYeP386GNBdJinTixbFW/5VYt8VPC78YkQsp I3IhW+LOe1QDda7iPsItziEz7atf0XRqM3+MTkqWzoA64wlyJm+W+prb+bf1Z9dv Cp0I3Vtik4BskVFGp7rX1R0wH7GoG/uZXGVdabndZ4Lg/PdmyDG4bkrY8ecMUoZ4 8W931kSlk/IHpXdSzFRjDoMlClK3fhB7vM8mi4DGBy+dShs3AGSldfbTl2Q7qONB J5tIWGKStuDzZXXbNT7K/IKNICHXgff04gmIwuajK/0FFADaL+lN0JQL941K5yQM 14i6nKc1GVDpMh+V8yy6b5qGSG5xNWPexKfhPwXiJ/CBn2IHy0yLakXBGyK5cPyQ XZN6ia5urxPBhraDOBV60MChuICckk6gtorD52rtIBM2KFIWoSBEpfjZV4vDh41i xy1yXXyb3LpJnVMJlmQrkhNV6hT511zu11TJu4JVFjauYzpZ75+qnPe07NDAITgr Cn5iBSSKkNXHU5cWDb3I =Tgc8 -----END PGP SIGNATURE----- --GVku4NflTQVFtWKQ8fFINdaugJ7PfVgv9-- --===============8046291450436696475== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============8046291450436696475==--