From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54438)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1agSc4-00085L-Qd
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 03:44:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1agSbz-000387-Of
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 03:44:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53824)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1agSbz-000383-Ir
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 03:44:51 -0400
References: <1458124733-13901-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<1458124733-13901-2-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<56EA51FD.1020002@redhat.com> <56EA5599.4090202@cn.fujitsu.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56EA606C.7020703@redhat.com>
Date: Thu, 17 Mar 2016 15:44:44 +0800
MIME-Version: 1.0
In-Reply-To: <56EA5599.4090202@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V5 1/2] net/filter-mirror: implement
 filter-redirector
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Zhijian <lizhijian@cn.fujitsu.com>, Zhang Chen <zhangchen.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>
Cc: Gui jianfeng <guijianfeng@cn.fujitsu.com>, Yang Hongyang <hongyang.yang@easystack.cn>, "eddie.dong" <eddie.dong@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>



On 03/17/2016 02:58 PM, Li Zhijian wrote:
>>>
>>> +            } else {
>>> +                error_report("%s, serious error: oversized packet
>>> received,"
>>> +                             "connection terminated.", __func__);
>>
>> The connection was not terminated actually. And since the warning is
>> unique, __func__ is probably not necessary.
>
> this warning message is copy from net_socket_send(), So i add __func__ to
> distinguish them.
>

I see.

> So "redirector serious error: oversized packet received" is enough. 

Right.

Thanks