From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57133)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1agSq6-0006gf-7K
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 03:59:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1agSq2-0006dM-4C
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 03:59:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1agSq1-0006dG-UE
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 03:59:22 -0400
References: <1458199928-6040-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<1458199928-6040-2-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<56EA61DD.6050005@cn.fujitsu.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56EA63D1.6060302@redhat.com>
Date: Thu, 17 Mar 2016 15:59:13 +0800
MIME-Version: 1.0
In-Reply-To: <56EA61DD.6050005@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V6 1/2] net/filter-mirror: implement
 filter-redirector
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Zhijian <lizhijian@cn.fujitsu.com>, Zhang Chen <zhangchen.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>
Cc: Gui jianfeng <guijianfeng@cn.fujitsu.com>, Yang Hongyang <hongyang.yang@easystack.cn>, "eddie.dong" <eddie.dong@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>



On 03/17/2016 03:50 PM, Li Zhijian wrote:
>>
>> +static void filter_redirector_fini(Object *obj)
>> +{
>> +    MirrorState *s = FILTER_REDIRECTOR(obj);
>> +
>> +    qemu_chr_add_handlers(s->chr_in, NULL, NULL, NULL, NULL);
>
> hi, Jason
> Do we reset the chardev handler here is reasonable ?
> filter_redirector_fini() is destruction of filter_redirector_init()
> which we
> don't register handler.
>
> So, I think move the handler reset to filter_redirector_cleanup()
> would be better.
>
> Thanks
> Li 

Yes, please.

Thanks