All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pascal Huerst <pascal.huerst@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: adau1701: Different sample rates need different firmwares
Date: Thu, 17 Mar 2016 11:51:24 +0100	[thread overview]
Message-ID: <56EA8C2C.4010606@gmail.com> (raw)

Hey Lars,

I'm having an issue with the adau1701 codec. There is this line which
checks, if the mclk/lrclk ratio has changed and whether it is necessary
to reset the codec and upload a new firmware.

http://lxr.free-electrons.com/source/sound/soc/codecs/adau1701.c#L444

But if we change mclk in the machine driver (for example to playback
44.1), this ration might not change, but still we have to upload a new
firmware, so shouldn't we probably be checking for sample rate changes
instead:

if (adau1701->current_rate != params_rate(params) {
	adau1701->current_rate = params_rate(params);
	ret = adau1701_reset(codec, clkdiv, params_rate(params));
	if (ret < 0)
		return ret;
}

Or did I miss something?

regards
pascal

             reply	other threads:[~2016-03-17 10:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 10:51 Pascal Huerst [this message]
2016-03-17 12:40 ` adau1701: Different sample rates need different firmwares Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EA8C2C.4010606@gmail.com \
    --to=pascal.huerst@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lars@metafoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.