All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Prakash, Prashanth" <pprakash@codeaurora.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	harba@codeaurora.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
Subject: Re: [PATCH 1/3] ACPI: move ACPI_SYSTEM_HID to acpi_drivers.h
Date: Thu, 17 Mar 2016 10:53:31 -0600	[thread overview]
Message-ID: <56EAE10B.8070404@codeaurora.org> (raw)
In-Reply-To: <CAJZ5v0jewRqgvi7Ei939ddafnNJEQw+cv2cjGWrFNK2pZ0-2rQ@mail.gmail.com>

Hi Rafael,

On 3/16/2016 7:50 PM, Rafael J. Wysocki wrote:
>  #include "internal.h"
> @@ -22,7 +24,6 @@ ACPI_MODULE_NAME("scan");
>  extern struct acpi_device *acpi_root;
>
>  #define ACPI_BUS_CLASS                 "system_bus"
> -#define ACPI_BUS_HID                   "LNXSYBUS"
> No.
>
> This is not a valid device ID and should never be used as such.
Section 5.6.6 in ACPI 6.1 is defining the notification value for the graceful
shutdown request as a ACPI device specific value(0x81) and it is targeting
the system bus(\_SB), so we took the current approach of creating a sybus
driver to handle the notifications targeting the system bus.

Let me go through the code again and see if we can avoid using the
ACPI_BUS_HID. In the meantime, if you have any specific thoughts on
how this should be handled, please let us know.

Thanks,
Prashanth


  reply	other threads:[~2016-03-17 16:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 19:36 [PATCH 0/3] ACPI: Support for platform initiated graceful shutdown Prashanth Prakash
2016-03-16 19:37 ` [PATCH 1/3] ACPI: move ACPI_SYSTEM_HID to acpi_drivers.h Prashanth Prakash
2016-03-17  1:50   ` Rafael J. Wysocki
2016-03-17 16:53     ` Prakash, Prashanth [this message]
2016-03-17 21:54       ` Rafael J. Wysocki
2016-03-18 15:33         ` Prakash, Prashanth
2016-03-16 19:37 ` [PATCH 2/3] ACPI / sybus: add a driver for LNXSYBUS device Prashanth Prakash
2016-03-16 19:37 ` [PATCH 3/3] ACPI: update the definition of common notification values Prashanth Prakash
2016-05-10 22:50 ` [PATCH 0/3] ACPI: Support for platform initiated graceful shutdown Al Stone
2016-05-10 23:28   ` Prakash, Prashanth
2016-05-11 20:59     ` Al Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EAE10B.8070404@codeaurora.org \
    --to=pprakash@codeaurora.org \
    --cc=harba@codeaurora.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=zjzhang@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.