Re: [PATCH 2/9] gprs-context.h: add op for reading context config

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

Hi Dragos,

On 03/17/2016 12:02 PM, Dragos Tatulea wrote:
> This will be implemented by a gprs-context driver to support
> automatic context activation. The gprs atom will call the driver
> to read the ip configuration without activating the context.
> ---
>   include/gprs-context.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/gprs-context.h b/include/gprs-context.h
> index 0090cc4..b792fc6 100644
> --- a/include/gprs-context.h
> +++ b/include/gprs-context.h
> @@ -79,6 +79,9 @@ struct ofono_gprs_context_driver {
>   					ofono_gprs_context_cb_t cb, void *data);
>   	void (*detach_shutdown)(struct ofono_gprs_context *gc,
>   					unsigned int id);
> +	void (*read_settings)(struct ofono_gprs_context *gc,
> +				const struct ofono_gprs_primary_context *ctx,
> +				ofono_gprs_context_cb_t cb, void *data);

Why does it take ofono_gprs_primary_context as input.  Wouldn't the cid 
be enough?

>   };
>
>   void ofono_gprs_context_deactivated(struct ofono_gprs_context *gc,
>

Regards,
-Denis