From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 17 Mar 2016 11:35:39 -0600 Subject: [U-Boot] [PATCH 1/2] ARM: bcm283x: don't always define CONFIG_BCM2835 In-Reply-To: <20160317155431.GZ23166@bill-the-cat> References: <1458186057-30980-1-git-send-email-swarren@wwwdotorg.org> <20160317155431.GZ23166@bill-the-cat> Message-ID: <56EAEAEB.4040808@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/17/2016 09:54 AM, Tom Rini wrote: > On Wed, Mar 16, 2016 at 09:40:56PM -0600, Stephen Warren wrote: > >> Currently, CONFIG_BCM2835 is defined for all BCM283x builds and _BCM2836 >> is defined when building for that SoC. That means there isn't a single >> define that means "exactly BCM2835". This will complicate future patches >> where BCM2835-vs-anything-else needs to be determined simply. >> >> Modify the code to define one or the other of CONFIG_BCM2835/BCM2836 so >> future patches are simpler. >> >> Signed-off-by: Stephen Warren > [snip] >> diff --git a/include/configs/rpi.h b/include/configs/rpi.h >> index 86422e390da2..a788ce42e44c 100644 >> --- a/include/configs/rpi.h >> +++ b/include/configs/rpi.h >> @@ -7,6 +7,7 @@ >> #ifndef __CONFIG_H >> #define __CONFIG_H >> >> +#define CONFIG_BCM2835 >> #define CONFIG_SYS_CACHELINE_SIZE 32 >> >> #include "rpi-common.h" > > Shouldn't we take this as the time to move it to > arch/arm/mach-bcm283x/Kconfig ? It is probably time yes, although I'd rather do that in a separate patch either way. I should be able to work that patch up before sending the actual RPi3 board file patches.