From mboxrd@z Thu Jan  1 00:00:00 1970
From: Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH v4 04/14] firmware/makefile: install BIOS
 blob ...
Date: Thu, 17 Mar 2016 12:37:36 -0500
Message-ID: <56EAEB60.7040303@cardoe.com>
References: <1457978150-27201-1-git-send-email-anthony.perard@citrix.com>
 <1457978150-27201-5-git-send-email-anthony.perard@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5166636528532198008=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1457978150-27201-5-git-send-email-anthony.perard@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============5166636528532198008==
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="7Dirb3SgnTvpCSnIAmBNCNPsSUnLIxxBt"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--7Dirb3SgnTvpCSnIAmBNCNPsSUnLIxxBt
Content-Type: multipart/mixed; boundary="2e1rDVE25c1RNfIqPEUAEFJeRDCJlTiAc"
From: Doug Goldstein <cardoe@cardoe.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>,
 Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Message-ID: <56EAEB60.7040303@cardoe.com>
Subject: Re: [Xen-devel] [PATCH v4 04/14] firmware/makefile: install BIOS blob
 ...
References: <1457978150-27201-1-git-send-email-anthony.perard@citrix.com>
 <1457978150-27201-5-git-send-email-anthony.perard@citrix.com>
In-Reply-To: <1457978150-27201-5-git-send-email-anthony.perard@citrix.com>

--2e1rDVE25c1RNfIqPEUAEFJeRDCJlTiAc
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 3/14/16 12:55 PM, Anthony PERARD wrote:
> ... into the firmware directory, along with hvmloader.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> Change in V4:
> - remove install of acpi dsdt table
>=20
> Change in V3:
> - do not check if ROMs file exist before installing, they should exist
> - change rules for dsdt_anycpu_qemu_xen.c in oder to generate both .c a=
nd
>   .aml files without changing temporarly the other dsdt_*.c rules.
> ---
>  tools/firmware/Makefile | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>=20
> diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
> index 6cc86ce..6a37758 100644
> --- a/tools/firmware/Makefile
> +++ b/tools/firmware/Makefile
> @@ -19,6 +19,9 @@ SUBDIRS-y +=3D hvmloader
> =20
>  LD32BIT-$(CONFIG_FreeBSD) :=3D LD32BIT_FLAG=3D-melf_i386_fbsd
> =20
> +SEABIOS_ROM :=3D seabios-dir/out/bios.bin
> +OVMF_ROM :=3D ovmf-dir/ovmf.bin
> +
>  ovmf-dir:
>  	GIT=3D$(GIT) $(XEN_ROOT)/scripts/git-checkout.sh $(OVMF_UPSTREAM_URL)=
 $(OVMF_UPSTREAM_REVISION) ovmf-dir
>  	cp ovmf-makefile ovmf-dir/Makefile;
> @@ -45,6 +48,16 @@ endif
>  install: all
>  	[ -d $(INST_DIR) ] || $(INSTALL_DIR) $(INST_DIR)
>  	[ ! -e $(TARGET) ] || $(INSTALL_DATA) $(TARGET) $(INST_DIR)
> +ifeq ($(CONFIG_SEABIOS),y)
> +ifeq ($(SEABIOS_PATH),)
> +	$(INSTALL_DATA) $(SEABIOS_ROM) $(INST_DIR)/seabios.bin

Why install this as "seabios.bin" when the default is "bios.bin". Most
distro's packages for SeaBIOS install it as "bios.bin"


> +endif
> +endif
> +ifeq ($(CONFIG_OVMF),y)
> +ifeq ($(OVMF_PATH),)
> +	$(INSTALL_DATA) $(OVMF_ROM) $(INST_DIR)/ovmf.bin
> +endif
> +endif
> =20
>  .PHONY: clean
>  clean: subdirs-clean
>=20


--=20
Doug Goldstein


--2e1rDVE25c1RNfIqPEUAEFJeRDCJlTiAc--

--7Dirb3SgnTvpCSnIAmBNCNPsSUnLIxxBt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0

iQJ8BAEBCgBmBQJW6utjXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB
MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUkrgP/Rs0A5CAjVD/POFn48PpBnu2
2SQx0peqa6R3/XsLkNcqFMNvRYtbnUWhhL9Eeh9CWyqSDTpEsWCXUAUQEfygQxlf
dzdRGNTpueVR49IG7Wgf/rKd+ItqKoc4Xcs4ZeynRzNYqI0gRYTPjsjw4wg3hqRW
Nwtbn+5oLPn2v6ZYHKkMsCOnBagWrJw3nJ6jRocPNqTtt118A05kM53548xrKKYt
yWbNyP3upsPog1XPxKuTgcF4VEE8dqy7JNHtYn1d9IUo4A91kU22b2+G6NVjnaTv
Se2hhwKARRTEDAP5TXi2mvtMla3faYzi6+CFjhx5j9YRRjZ06tMdJ621eVAe5jaa
xQTrnA9EA8ygXPCgmVDyN/ASXfc8voFKz9ZhsWt/1tEZynCxVdEEAmYKgVy7pguN
CTnzLwhcHgsPVFX2sd1NIf+VvtL4rvBviPdAvyDAz02zYTimsykIniDUtB7nSMIh
NPhB4V+DC9PjQadtriHKU8cr4WGjuuhRoao2gaeT3EYC/+pJENftoIU0vzO+EQs5
GfUBLooktN6RDX2IvSGdxzsSTIR5Z+iZ3le5YmjRCdacqT5gKU558LkfE0LQ0cv/
oJm1+CNkvL16UznWiOLR3URxcNZJs5DRs8/avtL7ecJy/Brmwz7+UWC/K0tNO6bA
YFJ9q8QuTshkrHsETavu
=q2hF
-----END PGP SIGNATURE-----

--7Dirb3SgnTvpCSnIAmBNCNPsSUnLIxxBt--


--===============5166636528532198008==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============5166636528532198008==--