From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH v3 3/5] main: Safely free watch_data structures
Date: Thu, 17 Mar 2016 13:35:57 -0500 [thread overview]
Message-ID: <56EAF90D.1090805@gmail.com> (raw)
In-Reply-To: <1458238542-11711-3-git-send-email-mathew.j.martineau@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
Hi Mat,
On 03/17/2016 01:15 PM, Mat Martineau wrote:
> The race condition test in test-main exposed a case where the events
> array returned by epoll_wait could have a stale watch_data
> pointer. This triggered a use-after-free error that was reported by
> the address sanitizer (./configure --enable-asan).
>
> When the event loop is running, watch_data structures with events
> being dispatched are flagged. If watch_remove is called on a flagged
> structure, the l_free() is deferred until after all events are
> dispatched and the callback for that event is skipped.
> ---
> ell/main.c | 31 +++++++++++++++++++++++++++++--
> 1 file changed, 29 insertions(+), 2 deletions(-)
>
Patches 3-5 applied. Thanks.
Regards,
-Denis
next prev parent reply other threads:[~2016-03-17 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 18:15 [PATCH v3 1/5] build: Add sanitizer options Mat Martineau
2016-03-17 18:15 ` [PATCH v3 2/5] unit: Add race condition test to test-main Mat Martineau
2016-03-17 18:17 ` Mat Martineau
2016-03-17 18:19 ` [PATCH v4 " Mat Martineau
2016-03-17 18:35 ` Denis Kenzior
2016-03-17 18:15 ` [PATCH v3 3/5] main: Safely free watch_data structures Mat Martineau
2016-03-17 18:35 ` Denis Kenzior [this message]
2016-03-17 18:15 ` [PATCH v3 4/5] main: Remove unnecessary error check Mat Martineau
2016-03-17 18:15 ` [PATCH v3 5/5] unit: Add test-main check for self-removal Mat Martineau
2016-03-25 21:51 ` [PATCH v3 1/5] build: Add sanitizer options Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EAF90D.1090805@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.