From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1agjJR-0005Jr-59
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 21:34:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1agjJN-0002v7-RR
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 21:34:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50253)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1agjJN-0002ty-MW
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 21:34:45 -0400
References: <1458200278-11940-1-git-send-email-sameeh@daynix.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56EB5B30.80200@redhat.com>
Date: Fri, 18 Mar 2016 09:34:40 +0800
MIME-Version: 1.0
In-Reply-To: <1458200278-11940-1-git-send-email-sameeh@daynix.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] e1000: Introducing an upper bound of
	interrupts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sameeh Jubran <sameeh@daynix.com>, qemu-devel@nongnu.org
Cc: Dmitry Fleytman <dmitry@daynix.com>, Yan Vugenfirer <yan@daynix.com>



On 03/17/2016 03:37 PM, Sameeh Jubran wrote:
> This patch series introduces an upper bound for the number of interrupts
> per second. This feature is supported by the real hardware, however up
> until now it wasn't implemented in e1000. This feature is very
> significant, it can prevent an interrupt storm by giving the driver
> a bounded inter-interrupt interval to handle interrupts.
>
> This patch was made after observing an interrupt storm in Windows 10
> when disabling e1000.
>
> How reproducible:
>
> Steps to reproduce:
> 1. Start Win 10 guest with e1000 device.
> 2. Go to device manager and try to disable and enable the device.
> 3. After several enable/disable to the device the guest hangs when
> the device is being disabled.
>
> Actual results:
> Guest hang after click OK button.
>
> Expected results:
> Device is disabled.
>
> After applying the patch the guest no longer hangs, and an Iperf test
> ran successfully.
>
> Sameeh Jubran (2):
>   e1000: Fixing interrupts pace.
>   Revert "e1000: fix hang of win2k12 shutdown with flood ping"
>
>  hw/net/e1000.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>

Applied.

Thanks Sameeh