From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kardashevskiy Date: Fri, 18 Mar 2016 02:34:45 +0000 Subject: Re: Problem with merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm Message-Id: <56EB6945.3020402@ozlabs.ru> List-Id: References: <56EAD85A.3060309@xenosoft.de> <56EB0D19.2090000@redhat.com> In-Reply-To: <56EB0D19.2090000@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paolo Bonzini , Christian Zigotzky , kvm@vger.kernel.org, "kvm-ppc@vger.kernel.org" , Paul Mackerras On 03/18/2016 07:01 AM, Paolo Bonzini wrote: > > > On 17/03/2016 17:16, Christian Zigotzky wrote: >> >> I downloaded the latest Git version of the Linux kernel today. >> Unfortunately I wasn't able to compile the kvm-pr kernel module today. >> >> Error messages: >> >> Building modules, stage 2. >> MODPOST 29 modules >> ERROR: ".kvmppc_h_put_tce" [arch/powerpc/kvm/kvm-pr.ko] undefined! >> ERROR: ".kvmppc_h_stuff_tce" [arch/powerpc/kvm/kvm-pr.ko] undefined! >> make[1]: *** [__modpost] Fehler 1 >> make: *** [modules] Fehler 2 >> >> Yesterday, I tested the latest Git version of the Linux kernel too. I >> was able to compile the kvm-pr kernel module yesterday. After that I >> successfully tested it with Mac-on-Linux and Mac OS X Tiger yesterday. >> >> I think the problem is in the latest KVM updates. Link: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?iddc3747661bea9215417b659449bb7b8ed3df2c > > Paul and Alexey, can you take a look? I guess I can figure it out, but > let's use the timezone difference to our advantage for once. :) The missing handlers are only compiled when HV KVM is enabled, I made this change in the very last respin of my patchset after a comment that having duplicated code is bad and this happened right before it was pulled to Paul's tree. My bad, apologies... I'll post a fix soon. -- Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kardashevskiy Subject: Re: Problem with merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm Date: Fri, 18 Mar 2016 13:34:45 +1100 Message-ID: <56EB6945.3020402@ozlabs.ru> References: <56EAD85A.3060309@xenosoft.de> <56EB0D19.2090000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit To: Paolo Bonzini , Christian Zigotzky , kvm@vger.kernel.org, "kvm-ppc@vger.kernel.org" , Paul Mackerras Return-path: Received: from mail-pf0-f172.google.com ([209.85.192.172]:34411 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbcCRCew (ORCPT ); Thu, 17 Mar 2016 22:34:52 -0400 Received: by mail-pf0-f172.google.com with SMTP id x3so146211136pfb.1 for ; Thu, 17 Mar 2016 19:34:52 -0700 (PDT) In-Reply-To: <56EB0D19.2090000@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/18/2016 07:01 AM, Paolo Bonzini wrote: > > > On 17/03/2016 17:16, Christian Zigotzky wrote: >> >> I downloaded the latest Git version of the Linux kernel today. >> Unfortunately I wasn't able to compile the kvm-pr kernel module today. >> >> Error messages: >> >> Building modules, stage 2. >> MODPOST 29 modules >> ERROR: ".kvmppc_h_put_tce" [arch/powerpc/kvm/kvm-pr.ko] undefined! >> ERROR: ".kvmppc_h_stuff_tce" [arch/powerpc/kvm/kvm-pr.ko] undefined! >> make[1]: *** [__modpost] Fehler 1 >> make: *** [modules] Fehler 2 >> >> Yesterday, I tested the latest Git version of the Linux kernel too. I >> was able to compile the kvm-pr kernel module yesterday. After that I >> successfully tested it with Mac-on-Linux and Mac OS X Tiger yesterday. >> >> I think the problem is in the latest KVM updates. Link: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=10dc3747661bea9215417b659449bb7b8ed3df2c > > Paul and Alexey, can you take a look? I guess I can figure it out, but > let's use the timezone difference to our advantage for once. :) The missing handlers are only compiled when HV KVM is enabled, I made this change in the very last respin of my patchset after a comment that having duplicated code is bad and this happened right before it was pulled to Paul's tree. My bad, apologies... I'll post a fix soon. -- Alexey