From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ago3A-0002lJ-GM for qemu-devel@nongnu.org; Fri, 18 Mar 2016 02:38:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ago37-0005bG-9v for qemu-devel@nongnu.org; Fri, 18 Mar 2016 02:38:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ago37-0005b5-4d for qemu-devel@nongnu.org; Fri, 18 Mar 2016 02:38:17 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 8F1A4711D0 for ; Fri, 18 Mar 2016 06:38:16 +0000 (UTC) Received: from wei-thinkpad.nay.redhat.com (vpn1-6-235.pek2.redhat.com [10.72.6.235]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2I6cE8D023507 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 18 Mar 2016 02:38:15 -0400 References: <1458033424-25414-1-git-send-email-wexu@redhat.com> <1458033424-25414-2-git-send-email-wexu@redhat.com> <56EA6DE2.7070502@redhat.com> <56EADF28.3000101@redhat.com> <56EB61D8.8080202@redhat.com> <56EB816D.5000804@redhat.com> <56EB902F.1070506@redhat.com> From: Wei Xu Message-ID: <56EBA255.3090608@redhat.com> Date: Fri, 18 Mar 2016 14:38:13 +0800 MIME-Version: 1.0 In-Reply-To: <56EB902F.1070506@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 2016=E5=B9=B403=E6=9C=8818=E6=97=A5 13:20, Jason Wang wrote: > > On 03/18/2016 12:17 PM, Wei Xu wrote: >>>>>> +static ssize_t virtio_net_receive(NetClientState *nc, >>>>>> + const uint8_t *buf, size_t size= ) >>>>>> +{ >>>>>> + if (virtio_net_rsc_bypass) { >>>>>> + return virtio_net_do_receive(nc, buf, size); >>>>> You need a feature bit for this and compat it for older machine typ= es. >>>>> And also need some work on virtio spec I think. >>>> yes, not sure which way is good to support this, hmp/qmp/ethtool, th= is >>>> is gonna to support win guest, >>>> so need a well-compatible interface, any comments? >>> I think this should be implemented through feature bits/negotiation >>> instead of something like ethtool. >> Looks this feature should be turn on/off dynamically due to the spec, >> so maybe this should be managed from the guest, is there any reference >> code for this? > Then you may want to look at implementation of > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. Have a short look at it, do you know how to control the feature bit? =20 both when lauching vm and changing it during runtime?