diff for duplicates of <56EBC5D8.6050901@redhat.com> diff --git a/a/1.txt b/N1/1.txt index b8ba081..3cf7bb4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,9 +25,9 @@ On 16.03.2016 16:13, Laurent Vivier wrote: > + * - Data are loaded into 4 low order bytes of registers (Word). > + * - The unfilled bytes are set to 0. > + * - The sequence of registers wraps around to GPR0. -> + * - if n = 0, content of RT is undefined +> + * - if n == 0, content of RT is undefined > + * - RT <= RA or RB < RT + (n + 4) is invalid or result is undefined -> + * - RT = RA = 0 is invalid +> + * - RT == RA == 0 is invalid > + * > + */ > + @@ -76,7 +76,7 @@ here!? I think you need "memory" in the clobber list, since you write to the regs buffer. -> + report("partial", regs[0] = 0x01020300 && regs[1] = (uint64_t)-1); +> + report("partial", regs[0] == 0x01020300 && regs[1] == (uint64_t)-1); > + > + /* check an old know bug: the number of bytes is used as > + * the number of registers, so try 32 bytes. @@ -114,11 +114,11 @@ regs buffer. Please also add "memory" here. -> + report("length", regs[0] = 0x01020304 && regs[1] = 0x05060708 && -> + regs[2] = 0x090a0b0c && regs[3] = 0x0d0e0f10 && -> + regs[4] = 0x11121314 && regs[5] = 0x15161718 && -> + regs[6] = 0x191a1b1c && regs[7] = 0x1d1e1f20 && -> + regs[8] = (uint64_t)-1); +> + report("length", regs[0] == 0x01020304 && regs[1] == 0x05060708 && +> + regs[2] == 0x090a0b0c && regs[3] == 0x0d0e0f10 && +> + regs[4] == 0x11121314 && regs[5] == 0x15161718 && +> + regs[6] == 0x191a1b1c && regs[7] == 0x1d1e1f20 && +> + regs[8] == (uint64_t)-1); > + > + /* check wrap around to r0 */ > + @@ -144,8 +144,8 @@ Comment also needs to be fixed? "memory" missing again -> + report("wrap around to r0", regs[0] = 0x01020304 && -> + regs[1] = 0x05060708); +> + report("wrap around to r0", regs[0] == 0x01020304 && +> + regs[1] == 0x05060708); > + > + /* check wrap around to r0 over RB doesn't break RB */ > + @@ -180,7 +180,7 @@ That comment needs some update, too. > + * overwrite the register. > + * In all the cases, the register must stay untouched > + */ -> + report("Don't overwrite Rb", regs[1] = (uint64_t)addr); +> + report("Don't overwrite Rb", regs[1] == (uint64_t)addr); Huh, how can this KVM unit test ever finish successfully if real processor stops? Should this last test maybe be optional and only be diff --git a/a/content_digest b/N1/content_digest index 1d1ac62..9e2ac2b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01458141183-27207-5-git-send-email-lvivier@redhat.com\0" "From\0Thomas Huth <thuth@redhat.com>\0" "Subject\0Re: [kvm-unit-tests PATCH 4/5] powerpc: check lswx\0" - "Date\0Fri, 18 Mar 2016 09:09:44 +0000\0" + "Date\0Fri, 18 Mar 2016 10:09:44 +0100\0" "To\0Laurent Vivier <lvivier@redhat.com>" kvm@vger.kernel.org " kvm-ppc@vger.kernel.org\0" @@ -38,9 +38,9 @@ "> + * - Data are loaded into 4 low order bytes of registers (Word).\n" "> + * - The unfilled bytes are set to 0.\n" "> + * - The sequence of registers wraps around to GPR0.\n" - "> + * - if n = 0, content of RT is undefined\n" + "> + * - if n == 0, content of RT is undefined\n" "> + * - RT <= RA or RB < RT + (n + 4) is invalid or result is undefined\n" - "> + * - RT = RA = 0 is invalid\n" + "> + * - RT == RA == 0 is invalid\n" "> + *\n" "> + */\n" "> +\n" @@ -89,7 +89,7 @@ "I think you need \"memory\" in the clobber list, since you write to the\n" "regs buffer.\n" "\n" - "> +\treport(\"partial\", regs[0] = 0x01020300 && regs[1] = (uint64_t)-1);\n" + "> +\treport(\"partial\", regs[0] == 0x01020300 && regs[1] == (uint64_t)-1);\n" "> +\n" "> +\t/* check an old know bug: the number of bytes is used as\n" "> +\t * the number of registers, so try 32 bytes.\n" @@ -127,11 +127,11 @@ "\n" "Please also add \"memory\" here.\n" "\n" - "> +\treport(\"length\", regs[0] = 0x01020304 && regs[1] = 0x05060708 &&\n" - "> +\t\t\t regs[2] = 0x090a0b0c && regs[3] = 0x0d0e0f10 &&\n" - "> +\t\t\t regs[4] = 0x11121314 && regs[5] = 0x15161718 &&\n" - "> +\t\t\t regs[6] = 0x191a1b1c && regs[7] = 0x1d1e1f20 &&\n" - "> +\t\t\t regs[8] = (uint64_t)-1);\n" + "> +\treport(\"length\", regs[0] == 0x01020304 && regs[1] == 0x05060708 &&\n" + "> +\t\t\t regs[2] == 0x090a0b0c && regs[3] == 0x0d0e0f10 &&\n" + "> +\t\t\t regs[4] == 0x11121314 && regs[5] == 0x15161718 &&\n" + "> +\t\t\t regs[6] == 0x191a1b1c && regs[7] == 0x1d1e1f20 &&\n" + "> +\t\t\t regs[8] == (uint64_t)-1);\n" "> +\n" "> +\t/* check wrap around to r0 */\n" "> +\n" @@ -157,8 +157,8 @@ "\n" "\"memory\" missing again\n" "\n" - "> +\treport(\"wrap around to r0\", regs[0] = 0x01020304 &&\n" - "> +\t\t\t regs[1] = 0x05060708);\n" + "> +\treport(\"wrap around to r0\", regs[0] == 0x01020304 &&\n" + "> +\t\t\t regs[1] == 0x05060708);\n" "> +\n" "> +\t/* check wrap around to r0 over RB doesn't break RB */\n" "> +\n" @@ -193,7 +193,7 @@ "> +\t * overwrite the register.\n" "> +\t * In all the cases, the register must stay untouched\n" "> +\t */\n" - "> +\treport(\"Don't overwrite Rb\", regs[1] = (uint64_t)addr);\n" + "> +\treport(\"Don't overwrite Rb\", regs[1] == (uint64_t)addr);\n" "\n" "Huh, how can this KVM unit test ever finish successfully if real\n" "processor stops? Should this last test maybe be optional and only be\n" @@ -215,4 +215,4 @@ "\n" Thomas -d8a0464f5c50102e3d673a3402764b2027d8c711c9fff178d45f39cf461fc7e1 +09bd16ed4d2f8cd7048a3e2b723dacc4614999eff752076c2e1bcf0644e725e6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.