diff for duplicates of <56EBD1F5.2070604@redhat.com> diff --git a/a/1.txt b/N1/1.txt index b00e901..358fa05 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -28,9 +28,9 @@ On 18/03/2016 10:09, Thomas Huth wrote: >> + * - Data are loaded into 4 low order bytes of registers (Word). >> + * - The unfilled bytes are set to 0. >> + * - The sequence of registers wraps around to GPR0. ->> + * - if n = 0, content of RT is undefined +>> + * - if n == 0, content of RT is undefined >> + * - RT <= RA or RB < RT + (n + 4) is invalid or result is undefined ->> + * - RT = RA = 0 is invalid +>> + * - RT == RA == 0 is invalid >> + * >> + */ >> + @@ -85,7 +85,7 @@ Yes, it's completely wrong... ok ->> + report("partial", regs[0] = 0x01020300 && regs[1] = (uint64_t)-1); +>> + report("partial", regs[0] == 0x01020300 && regs[1] == (uint64_t)-1); >> + >> + /* check an old know bug: the number of bytes is used as >> + * the number of registers, so try 32 bytes. @@ -128,11 +128,11 @@ always a bad cut'n'paste... ok ->> + report("length", regs[0] = 0x01020304 && regs[1] = 0x05060708 && ->> + regs[2] = 0x090a0b0c && regs[3] = 0x0d0e0f10 && ->> + regs[4] = 0x11121314 && regs[5] = 0x15161718 && ->> + regs[6] = 0x191a1b1c && regs[7] = 0x1d1e1f20 && ->> + regs[8] = (uint64_t)-1); +>> + report("length", regs[0] == 0x01020304 && regs[1] == 0x05060708 && +>> + regs[2] == 0x090a0b0c && regs[3] == 0x0d0e0f10 && +>> + regs[4] == 0x11121314 && regs[5] == 0x15161718 && +>> + regs[6] == 0x191a1b1c && regs[7] == 0x1d1e1f20 && +>> + regs[8] == (uint64_t)-1); >> + >> + /* check wrap around to r0 */ >> + @@ -164,8 +164,8 @@ yes, ok, > ->> + report("wrap around to r0", regs[0] = 0x01020304 && ->> + regs[1] = 0x05060708); +>> + report("wrap around to r0", regs[0] == 0x01020304 && +>> + regs[1] == 0x05060708); >> + >> + /* check wrap around to r0 over RB doesn't break RB */ >> + @@ -205,7 +205,7 @@ ok >> + * overwrite the register. >> + * In all the cases, the register must stay untouched >> + */ ->> + report("Don't overwrite Rb", regs[1] = (uint64_t)addr); +>> + report("Don't overwrite Rb", regs[1] == (uint64_t)addr); > > Huh, how can this KVM unit test ever finish successfully if real > processor stops? Should this last test maybe be optional and only be diff --git a/a/content_digest b/N1/content_digest index c36e2a4..89856ef 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\056EBC5D8.6050901@redhat.com\0" "From\0Laurent Vivier <lvivier@redhat.com>\0" "Subject\0Re: [kvm-unit-tests PATCH 4/5] powerpc: check lswx\0" - "Date\0Fri, 18 Mar 2016 10:01:25 +0000\0" + "Date\0Fri, 18 Mar 2016 11:01:25 +0100\0" "To\0Thomas Huth <thuth@redhat.com>" kvm@vger.kernel.org " kvm-ppc@vger.kernel.org\0" @@ -42,9 +42,9 @@ ">> + * - Data are loaded into 4 low order bytes of registers (Word).\n" ">> + * - The unfilled bytes are set to 0.\n" ">> + * - The sequence of registers wraps around to GPR0.\n" - ">> + * - if n = 0, content of RT is undefined\n" + ">> + * - if n == 0, content of RT is undefined\n" ">> + * - RT <= RA or RB < RT + (n + 4) is invalid or result is undefined\n" - ">> + * - RT = RA = 0 is invalid\n" + ">> + * - RT == RA == 0 is invalid\n" ">> + *\n" ">> + */\n" ">> +\n" @@ -99,7 +99,7 @@ "\n" "ok\n" "\n" - ">> +\treport(\"partial\", regs[0] = 0x01020300 && regs[1] = (uint64_t)-1);\n" + ">> +\treport(\"partial\", regs[0] == 0x01020300 && regs[1] == (uint64_t)-1);\n" ">> +\n" ">> +\t/* check an old know bug: the number of bytes is used as\n" ">> +\t * the number of registers, so try 32 bytes.\n" @@ -142,11 +142,11 @@ "\n" "ok\n" "\n" - ">> +\treport(\"length\", regs[0] = 0x01020304 && regs[1] = 0x05060708 &&\n" - ">> +\t\t\t regs[2] = 0x090a0b0c && regs[3] = 0x0d0e0f10 &&\n" - ">> +\t\t\t regs[4] = 0x11121314 && regs[5] = 0x15161718 &&\n" - ">> +\t\t\t regs[6] = 0x191a1b1c && regs[7] = 0x1d1e1f20 &&\n" - ">> +\t\t\t regs[8] = (uint64_t)-1);\n" + ">> +\treport(\"length\", regs[0] == 0x01020304 && regs[1] == 0x05060708 &&\n" + ">> +\t\t\t regs[2] == 0x090a0b0c && regs[3] == 0x0d0e0f10 &&\n" + ">> +\t\t\t regs[4] == 0x11121314 && regs[5] == 0x15161718 &&\n" + ">> +\t\t\t regs[6] == 0x191a1b1c && regs[7] == 0x1d1e1f20 &&\n" + ">> +\t\t\t regs[8] == (uint64_t)-1);\n" ">> +\n" ">> +\t/* check wrap around to r0 */\n" ">> +\n" @@ -178,8 +178,8 @@ "ok,\n" "\n" "> \n" - ">> +\treport(\"wrap around to r0\", regs[0] = 0x01020304 &&\n" - ">> +\t\t\t regs[1] = 0x05060708);\n" + ">> +\treport(\"wrap around to r0\", regs[0] == 0x01020304 &&\n" + ">> +\t\t\t regs[1] == 0x05060708);\n" ">> +\n" ">> +\t/* check wrap around to r0 over RB doesn't break RB */\n" ">> +\n" @@ -219,7 +219,7 @@ ">> +\t * overwrite the register.\n" ">> +\t * In all the cases, the register must stay untouched\n" ">> +\t */\n" - ">> +\treport(\"Don't overwrite Rb\", regs[1] = (uint64_t)addr);\n" + ">> +\treport(\"Don't overwrite Rb\", regs[1] == (uint64_t)addr);\n" "> \n" "> Huh, how can this KVM unit test ever finish successfully if real\n" "> processor stops? Should this last test maybe be optional and only be\n" @@ -253,4 +253,4 @@ "Thanks,\n" Laurent -f5270db571bafef6cfb0d8ec60242e6a6ce86585610b2f4fb3678ffd284fbd55 +d6d5236c73ef26abe3097e6105d087a6f6a73bc6b0da6f18430f05fe84f0b195
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.