From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: simplify bind_to_vm init code Date: Fri, 18 Mar 2016 11:10:50 +0000 Message-ID: <56EBE23A.5020506@linux.intel.com> References: <1458298019-3755-1-git-send-email-matthew.auld@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E2FB6E099 for ; Fri, 18 Mar 2016 11:10:52 +0000 (UTC) In-Reply-To: <1458298019-3755-1-git-send-email-matthew.auld@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matthew Auld , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxOC8wMy8xNiAxMDo0NiwgTWF0dGhldyBBdWxkIHdyb3RlOgo+IE5vIGZ1bmN0aW9uYWwg Y2hhbmdlLCBqdXN0IG1ha2VzIHRoZSBjb2RlIGVhc2llciB0byBmb2xsb3cuCj4KPiB2MjoKPiAg ICAgIC0gUmVtb3ZlIGxvY2FsIGZlbmNlX3NpemUgdmFyaWFibGUKPiAoVHZydGtvIFVyc3VsaW4p Cj4gICAgICAtIFJlbW92ZSByZWR1bmRhbnQgTlVMTCBnZ3R0X3ZpZXcgY2hlY2sKPiAgICAgIC0g UmV1c2Ugc2l6ZSB2YXJpYWJsZQo+Cj4gU2lnbmVkLW9mZi1ieTogTWF0dGhldyBBdWxkIDxtYXR0 aGV3LmF1bGRAaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYyB8IDUxICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gICAx IGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMzcgZGVsZXRpb25zKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCBmNDU4NTZkLi5lNWQ5ZDBiIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jCj4gQEAgLTM0NjgsNTAgKzM0NjgsMjcgQEAgaTkxNV9nZW1fb2JqZWN0 X2JpbmRfdG9fdm0oc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgIAl1MzIgZmVu Y2VfYWxpZ25tZW50LCB1bmZlbmNlZF9hbGlnbm1lbnQ7Cj4gICAJdTMyIHNlYXJjaF9mbGFnLCBh bGxvY19mbGFnOwo+ICAgCXU2NCBzdGFydCwgZW5kOwo+IC0JdTY0IHNpemUsIGZlbmNlX3NpemU7 Cj4gKwl1NjQgc2l6ZTsKPiAgIAlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiAgIAlpbnQgcmV0Owo+ Cj4gLQlpZiAoaTkxNV9pc19nZ3R0KHZtKSkgewo+IC0JCXUzMiB2aWV3X3NpemU7Cj4gLQo+IC0J CWlmIChXQVJOX09OKCFnZ3R0X3ZpZXcpKQo+IC0JCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsK PiAtCj4gLQkJdmlld19zaXplID0gaTkxNV9nZ3R0X3ZpZXdfc2l6ZShvYmosIGdndHRfdmlldyk7 Cj4gLQo+IC0JCWZlbmNlX3NpemUgPSBpOTE1X2dlbV9nZXRfZ3R0X3NpemUoZGV2LAo+IC0JCQkJ CQkgICB2aWV3X3NpemUsCj4gLQkJCQkJCSAgIG9iai0+dGlsaW5nX21vZGUpOwo+IC0JCWZlbmNl X2FsaWdubWVudCA9IGk5MTVfZ2VtX2dldF9ndHRfYWxpZ25tZW50KGRldiwKPiAtCQkJCQkJCSAg ICAgdmlld19zaXplLAo+IC0JCQkJCQkJICAgICBvYmotPnRpbGluZ19tb2RlLAo+IC0JCQkJCQkJ ICAgICB0cnVlKTsKPiAtCQl1bmZlbmNlZF9hbGlnbm1lbnQgPSBpOTE1X2dlbV9nZXRfZ3R0X2Fs aWdubWVudChkZXYsCj4gLQkJCQkJCQkJdmlld19zaXplLAo+IC0JCQkJCQkJCW9iai0+dGlsaW5n X21vZGUsCj4gLQkJCQkJCQkJZmFsc2UpOwo+IC0JCXNpemUgPSBmbGFncyAmIFBJTl9NQVBQQUJM RSA/IGZlbmNlX3NpemUgOiB2aWV3X3NpemU7Cj4gLQl9IGVsc2Ugewo+IC0JCWZlbmNlX3NpemUg PSBpOTE1X2dlbV9nZXRfZ3R0X3NpemUoZGV2LAo+IC0JCQkJCQkgICBvYmotPmJhc2Uuc2l6ZSwK PiAtCQkJCQkJICAgb2JqLT50aWxpbmdfbW9kZSk7Cj4gLQkJZmVuY2VfYWxpZ25tZW50ID0gaTkx NV9nZW1fZ2V0X2d0dF9hbGlnbm1lbnQoZGV2LAo+IC0JCQkJCQkJICAgICBvYmotPmJhc2Uuc2l6 ZSwKPiAtCQkJCQkJCSAgICAgb2JqLT50aWxpbmdfbW9kZSwKPiAtCQkJCQkJCSAgICAgdHJ1ZSk7 Cj4gLQkJdW5mZW5jZWRfYWxpZ25tZW50ID0KPiAtCQkJaTkxNV9nZW1fZ2V0X2d0dF9hbGlnbm1l bnQoZGV2LAo+IC0JCQkJCQkgICBvYmotPmJhc2Uuc2l6ZSwKPiAtCQkJCQkJICAgb2JqLT50aWxp bmdfbW9kZSwKPiAtCQkJCQkJICAgZmFsc2UpOwo+IC0JCXNpemUgPSBmbGFncyAmIFBJTl9NQVBQ QUJMRSA/IGZlbmNlX3NpemUgOiBvYmotPmJhc2Uuc2l6ZTsKPiAtCX0KPiArCWlmIChpOTE1X2lz X2dndHQodm0pKQo+ICsJCXNpemUgPSBpOTE1X2dndHRfdmlld19zaXplKG9iaiwgZ2d0dF92aWV3 KTsKPiArCWVsc2UKPiArCQlzaXplID0gb2JqLT5iYXNlLnNpemU7Cj4gKwo+ICsJZmVuY2VfYWxp Z25tZW50ID0gaTkxNV9nZW1fZ2V0X2d0dF9hbGlnbm1lbnQoZGV2LCBzaXplLAo+ICsJCQkJCQkg ICAgIG9iai0+dGlsaW5nX21vZGUsIHRydWUpOwo+ICsJdW5mZW5jZWRfYWxpZ25tZW50ID0gaTkx NV9nZW1fZ2V0X2d0dF9hbGlnbm1lbnQoZGV2LCBzaXplLAo+ICsJCQkJCQkJb2JqLT50aWxpbmdf bW9kZSwKPiArCQkJCQkJCWZhbHNlKTsKPgo+ICAgCXN0YXJ0ID0gZmxhZ3MgJiBQSU5fT0ZGU0VU X0JJQVMgPyBmbGFncyAmIFBJTl9PRkZTRVRfTUFTSyA6IDA7Cj4gICAJZW5kID0gdm0tPnRvdGFs Owo+IC0JaWYgKGZsYWdzICYgUElOX01BUFBBQkxFKQo+ICsJaWYgKGZsYWdzICYgUElOX01BUFBB QkxFKSB7Cj4gICAJCWVuZCA9IG1pbl90KHU2NCwgZW5kLCBkZXZfcHJpdi0+Z3R0Lm1hcHBhYmxl X2VuZCk7Cj4gKwkJc2l6ZSA9IGk5MTVfZ2VtX2dldF9ndHRfc2l6ZShkZXYsIHNpemUsIG9iai0+ dGlsaW5nX21vZGUpOwo+ICsJfQo+ICAgCWlmIChmbGFncyAmIFBJTl9aT05FXzRHKQo+ICAgCQll bmQgPSBtaW5fdCh1NjQsIGVuZCwgKDFVTEwgPDwgMzIpIC0gUEFHRV9TSVpFKTsKPgo+CgpMb29r cyBnb29kIHRvIG1lLgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxp bkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK