From: Zdenek Kabelac <zkabelac@redhat.com>
To: Werner Koch <wk@gnupg.org>, dm-devel@redhat.com
Subject: Re: [PATCH] dmsetup: improve message command
Date: Fri, 18 Mar 2016 12:52:27 +0100 [thread overview]
Message-ID: <56EBEBFB.6070107@redhat.com> (raw)
In-Reply-To: <8737rogi4v.fsf@wheatstone.g10code.de>
Dne 18.3.2016 v 12:06 Werner Koch napsal(a):
> On Fri, 26 Feb 2016 12:42, wk@gnupg.org said:
>
>> I am playing with a new crypto container format and propose to enhance
>> "dmsetup message" to accept the actual message from stdin instead of
>> taking it only from the command line. This is useful to set a key and
>
> Is there anything I can do to help you evaluate the patch?
>
Hi
It looked usable - thought could you trim down the zeroing of
dm-malloced area (wipememory) macro.
It's useless for heap allocation.
Unless you show example and compiler which would optimize 'library' call away.
a) such compiler would be horrible broken (since I could always LD_PRELOAD
my free() implementation),
b) we would need to do same for dm_task_struct - since your 'dmsetup mem
is duplicated for dm_task.
Regards
Zdenek
next prev parent reply other threads:[~2016-03-18 11:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 11:42 [PATCH] dmsetup: improve message command Werner Koch
2016-03-18 11:06 ` Werner Koch
2016-03-18 11:52 ` Zdenek Kabelac [this message]
2016-03-21 10:55 ` Werner Koch
2016-03-21 11:20 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EBEBFB.6070107@redhat.com \
--to=zkabelac@redhat.com \
--cc=dm-devel@redhat.com \
--cc=wk@gnupg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.