From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 01/14] drm/radeon: consolidate r600 uvd initialization and startup code. Date: Fri, 18 Mar 2016 17:44:54 +0100 Message-ID: <56EC3086.6090801@amd.com> References: <1458316719-30104-1-git-send-email-jglisse@redhat.com> <1458316719-30104-2-git-send-email-jglisse@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0084.outbound.protection.outlook.com [157.56.111.84]) by gabe.freedesktop.org (Postfix) with ESMTPS id C13186E016 for ; Fri, 18 Mar 2016 16:45:11 +0000 (UTC) In-Reply-To: <1458316719-30104-2-git-send-email-jglisse@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , dri-devel@lists.freedesktop.org Cc: Alex Deucher List-Id: dri-devel@lists.freedesktop.org QW0gMTguMDMuMjAxNiB1bSAxNjo1OCBzY2hyaWViIErDqXLDtG1lIEdsaXNzZToKPiBGcm9tOiBK w6lyb21lIEdsaXNzZSA8amdsaXNzZUByZWRoYXQuY29tPgo+Cj4gVGhpcyBtYXRjaCB0aGUgZXhh Y3Qgc2FtZSBjb250cm9sIGZsb3cgYXMgZXhpc3RpbmcgY29kZS4gSXQganVzdAo+IHVzZSBnb3Rv IGluc3RlYWQgb2YgbXVsdGlwbGUgbGV2ZWxzIG9mIGlmL2Vsc2UuIEl0IGFsc28gY2xhcmlmeQo+ IGVhcmx5IGluaXRpYWxpemF0aW9uIGZhaWx1cmVzIGJ5IGNsZWFyaW5nIHJkZXYtPmhhc191dmQg ZG9pbmcgc28KPiBkb2VzIG5vdCBjaGFuZ2UgZW5kIHJlc3VsdCBmcm9tIGhhcmR3YXJlIHBvaW50 IG9mIHZpZXcsIGl0IG9ubHkKPiBhdm9pZHMgcHJpbnRpbmcgbW9yZSBlcnJvciBtZXNzYWdlcyBk b3duIHRoZSBsaW5lIGFuZCB0aHVzIG9ubHkKPiB0aGUgb3JpZ2luYWwgZXJyb3IgaXMgcmVwb3J0 ZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNv bT4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IENjOiBD aHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+CgpQYXRjaGVzICM3IGFu ZCAjMTEtIzE0IGFyZSBSZXZpZXdlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyAKPGNocmlzdGlhbi5r b2VuaWdAYW1kLmNvbT4KClBhdGNoZXMgIzEtIzYgYW5kICM4LSMxMCBhcmUgQWNrZWQtYnk6IENo cmlzdGlhbiBLw7ZuaWcgCjxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+CgpUaGFua3MsCkNocmlz dGlhbi4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3I2MDAuYyB8IDk5ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2Vk LCA3MCBpbnNlcnRpb25zKCspLCAyOSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vcmFkZW9uL3I2MDAuYyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcjYwMC5j Cj4gaW5kZXggZjg2YWI2OS4uMjRmYTk4MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v cmFkZW9uL3I2MDAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcjYwMC5jCj4gQEAg LTMwMzUsNiArMzAzNSw3MyBAQCB2b2lkIHI2MDBfY2xlYXJfc3VyZmFjZV9yZWcoc3RydWN0IHJh ZGVvbl9kZXZpY2UgKnJkZXYsIGludCByZWcpCj4gICAJLyogRklYTUU6IGltcGxlbWVudCAqLwo+ ICAgfQo+ICAgCj4gK3N0YXRpYyB2b2lkIHI2MDBfdXZkX2luaXQoc3RydWN0IHJhZGVvbl9kZXZp Y2UgKnJkZXYpCj4gK3sKPiArCWludCByOwo+ICsKPiArCWlmICghcmRldi0+aGFzX3V2ZCkKPiAr CQlyZXR1cm47Cj4gKwo+ICsJciA9IHJhZGVvbl91dmRfaW5pdChyZGV2KTsKPiArCWlmIChyKSB7 Cj4gKwkJZGV2X2VycihyZGV2LT5kZXYsICJmYWlsZWQgVVZEICglZCkgaW5pdC5cbiIsIHIpOwo+ ICsJCS8qCj4gKwkJICogQXQgdGhpcyBwb2ludCByZGV2LT51dmQudmNwdV9ibyBpcyBOVUxMIHdo aWNoIHRyaWNrbGVzIGRvd24KPiArCQkgKiB0byBlYXJseSBmYWlscyB1dmRfdjFfMF9yZXN1bWUo KSBhbmQgdGh1cyBub3RoaW5nIGhhcHBlbnMKPiArCQkgKiB0aGVyZS4gU28gaXQgaXMgcG9pbnRs ZXNzIHRvIHRyeSB0byBnbyB0aHJvdWdoIHRoYXQgY29kZQo+ICsJCSAqIGhlbmNlIHdoeSB3ZSBk aXNhYmxlIHV2ZCBoZXJlLgo+ICsJCSAqLwo+ICsJCXJkZXYtPmhhc191dmQgPSAwOwo+ICsJCXJl dHVybjsKPiArCX0KPiArCXJkZXYtPnJpbmdbUjYwMF9SSU5HX1RZUEVfVVZEX0lOREVYXS5yaW5n X29iaiA9IE5VTEw7Cj4gKwlyNjAwX3JpbmdfaW5pdChyZGV2LCAmcmRldi0+cmluZ1tSNjAwX1JJ TkdfVFlQRV9VVkRfSU5ERVhdLCA0MDk2KTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgcjYwMF91 dmRfc3RhcnQoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4gK3sKPiArCWludCByOwo+ICsK PiArCWlmICghcmRldi0+aGFzX3V2ZCkKPiArCQlyZXR1cm47Cj4gKwo+ICsJciA9IHV2ZF92MV8w X3Jlc3VtZShyZGV2KTsKPiArCWlmIChyKSB7Cj4gKwkJZGV2X2VycihyZGV2LT5kZXYsICJmYWls ZWQgVVZEIHJlc3VtZSAoJWQpLlxuIiwgcik7Cj4gKwkJZ290byBlcnJvcjsKPiArCX0KPiArCXIg PSByYWRlb25fZmVuY2VfZHJpdmVyX3N0YXJ0X3JpbmcocmRldiwgUjYwMF9SSU5HX1RZUEVfVVZE X0lOREVYKTsKPiArCWlmIChyKSB7Cj4gKwkJZGV2X2VycihyZGV2LT5kZXYsICJmYWlsZWQgaW5p dGlhbGl6aW5nIFVWRCBmZW5jZXMgKCVkKS5cbiIsIHIpOwo+ICsJCWdvdG8gZXJyb3I7Cj4gKwl9 Cj4gKwlyZXR1cm47Cj4gKwo+ICtlcnJvcjoKPiArCXJkZXYtPnJpbmdbUjYwMF9SSU5HX1RZUEVf VVZEX0lOREVYXS5yaW5nX3NpemUgPSAwOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCByNjAwX3V2 ZF9yZXN1bWUoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4gK3sKPiArCXN0cnVjdCByYWRl b25fcmluZyAqcmluZzsKPiArCWludCByOwo+ICsKPiArCWlmICghcmRldi0+aGFzX3V2ZCB8fCAh cmRldi0+cmluZ1tSNjAwX1JJTkdfVFlQRV9VVkRfSU5ERVhdLnJpbmdfc2l6ZSkKPiArCQlyZXR1 cm47Cj4gKwo+ICsJcmluZyA9ICZyZGV2LT5yaW5nW1I2MDBfUklOR19UWVBFX1VWRF9JTkRFWF07 Cj4gKwlyID0gcmFkZW9uX3JpbmdfaW5pdChyZGV2LCByaW5nLCByaW5nLT5yaW5nX3NpemUsIDAs IFJBREVPTl9DUF9QQUNLRVQyKTsKPiArCWlmIChyKSB7Cj4gKwkJZGV2X2VycihyZGV2LT5kZXYs ICJmYWlsZWQgaW5pdGlhbGl6aW5nIFVWRCByaW5nICglZCkuXG4iLCByKTsKPiArCQlyZXR1cm47 Cj4gKwl9Cj4gKwlyID0gdXZkX3YxXzBfaW5pdChyZGV2KTsKPiArCWlmIChyKSB7Cj4gKwkJZGV2 X2VycihyZGV2LT5kZXYsICJmYWlsZWQgaW5pdGlhbGl6aW5nIFVWRCAoJWQpLlxuIiwgcik7Cj4g KwkJcmV0dXJuOwo+ICsJfQo+ICt9Cj4gKwo+ICAgc3RhdGljIGludCByNjAwX3N0YXJ0dXAoc3Ry dWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4gICB7Cj4gICAJc3RydWN0IHJhZGVvbl9yaW5nICpy aW5nOwo+IEBAIC0zMDcwLDE3ICszMTM3LDcgQEAgc3RhdGljIGludCByNjAwX3N0YXJ0dXAoc3Ry dWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4gICAJCXJldHVybiByOwo+ICAgCX0KPiAgIAo+IC0J aWYgKHJkZXYtPmhhc191dmQpIHsKPiAtCQlyID0gdXZkX3YxXzBfcmVzdW1lKHJkZXYpOwo+IC0J CWlmICghcikgewo+IC0JCQlyID0gcmFkZW9uX2ZlbmNlX2RyaXZlcl9zdGFydF9yaW5nKHJkZXYs IFI2MDBfUklOR19UWVBFX1VWRF9JTkRFWCk7Cj4gLQkJCWlmIChyKSB7Cj4gLQkJCQlkZXZfZXJy KHJkZXYtPmRldiwgImZhaWxlZCBpbml0aWFsaXppbmcgVVZEIGZlbmNlcyAoJWQpLlxuIiwgcik7 Cj4gLQkJCX0KPiAtCQl9Cj4gLQkJaWYgKHIpCj4gLQkJCXJkZXYtPnJpbmdbUjYwMF9SSU5HX1RZ UEVfVVZEX0lOREVYXS5yaW5nX3NpemUgPSAwOwo+IC0JfQo+ICsJcjYwMF91dmRfc3RhcnQocmRl dik7Cj4gICAKPiAgIAkvKiBFbmFibGUgSVJRICovCj4gICAJaWYgKCFyZGV2LT5pcnEuaW5zdGFs bGVkKSB7Cj4gQEAgLTMxMTAsMTcgKzMxNjcsNyBAQCBzdGF0aWMgaW50IHI2MDBfc3RhcnR1cChz dHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRldikKPiAgIAlpZiAocikKPiAgIAkJcmV0dXJuIHI7Cj4g ICAKPiAtCWlmIChyZGV2LT5oYXNfdXZkKSB7Cj4gLQkJcmluZyA9ICZyZGV2LT5yaW5nW1I2MDBf UklOR19UWVBFX1VWRF9JTkRFWF07Cj4gLQkJaWYgKHJpbmctPnJpbmdfc2l6ZSkgewo+IC0JCQly ID0gcmFkZW9uX3JpbmdfaW5pdChyZGV2LCByaW5nLCByaW5nLT5yaW5nX3NpemUsIDAsCj4gLQkJ CQkJICAgICBSQURFT05fQ1BfUEFDS0VUMik7Cj4gLQkJCWlmICghcikKPiAtCQkJCXIgPSB1dmRf djFfMF9pbml0KHJkZXYpOwo+IC0JCQlpZiAocikKPiAtCQkJCURSTV9FUlJPUigicmFkZW9uOiBm YWlsZWQgaW5pdGlhbGl6aW5nIFVWRCAoJWQpLlxuIiwgcik7Cj4gLQkJfQo+IC0JfQo+ICsJcjYw MF91dmRfcmVzdW1lKHJkZXYpOwo+ICAgCj4gICAJciA9IHJhZGVvbl9pYl9wb29sX2luaXQocmRl dik7Cj4gICAJaWYgKHIpIHsKPiBAQCAtMzI2NCwxMyArMzMxMSw3IEBAIGludCByNjAwX2luaXQo c3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4gICAJcmRldi0+cmluZ1tSQURFT05fUklOR19U WVBFX0dGWF9JTkRFWF0ucmluZ19vYmogPSBOVUxMOwo+ICAgCXI2MDBfcmluZ19pbml0KHJkZXYs ICZyZGV2LT5yaW5nW1JBREVPTl9SSU5HX1RZUEVfR0ZYX0lOREVYXSwgMTAyNCAqIDEwMjQpOwo+ ICAgCj4gLQlpZiAocmRldi0+aGFzX3V2ZCkgewo+IC0JCXIgPSByYWRlb25fdXZkX2luaXQocmRl dik7Cj4gLQkJaWYgKCFyKSB7Cj4gLQkJCXJkZXYtPnJpbmdbUjYwMF9SSU5HX1RZUEVfVVZEX0lO REVYXS5yaW5nX29iaiA9IE5VTEw7Cj4gLQkJCXI2MDBfcmluZ19pbml0KHJkZXYsICZyZGV2LT5y aW5nW1I2MDBfUklOR19UWVBFX1VWRF9JTkRFWF0sIDQwOTYpOwo+IC0JCX0KPiAtCX0KPiArCXI2 MDBfdXZkX2luaXQocmRldik7Cj4gICAKPiAgIAlyZGV2LT5paC5yaW5nX29iaiA9IE5VTEw7Cj4g ICAJcjYwMF9paF9yaW5nX2luaXQocmRldiwgNjQgKiAxMDI0KTsKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=