Re: [PATCH 0/8] Toaster improve test suite

["Aníbal Limón" <anibal.limon@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4196 bytes --]

Hi,

Comments below,

Kind regards,
	alimon

On 03/18/2016 10:29 AM, Brian Avery wrote:
> Hi,
> 
> I finally ran through the new version of the patch but I can't get it to run:
> A couple of issues
> 1) it needs rebasing on toaster-next, the rebase went cleanly though :)

I rebased it.

> 2) it can't find toasterconf.json (this can be worked around by
> setting TOASTER_CONF env variable for a quick test)

How you are starting toaster?, I'm using the helper that i create,
after source oe-env and create virtualenv. [1]

> 3) relies on being in /home/user/pokydir - this means it's unlikely
> anyone but AB would ever run it, I'd prefer that at least the top POKY
> dir is not a hard path

If you mean in the instructions [1] is only for example it works for any
directory.


> 4) migrations are failing:
> django.db.utils.OperationalError: cannot rollback - no transaction is active
> Failed migrations, aborting system start
> Failed start.

I'm not hitting this issue, may be is related to another thing.

[1]
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/tree/bitbake/lib/toaster/tests/README?h=alimon/toaster_tests_squash#n30

> 
> -b
> an intel employee
> 
> On Tue, Feb 23, 2016 at 9:31 AM, Aníbal Limón
> <anibal.limon@linux.intel.com> wrote:
>> This set of changes refactor/improve the current test suite now it can be
>> parameterized from command line.
>>
>> The main goal for this set of patches are for integrate the toaster
>> test suite into AB. The AB part is already on master. [1] If this patchset
>> is merged the way for run Toaster test suite will change for use it read
>> README in this patchset.
>>
>> Futher work are related to improve/fix the current test suite also i added
>> a TODO list.
>>
>> Also the changes can be found at,
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=alimon/toaster_tests_squash
>>
>> [1] http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?id=4ad04739d7414046775be84eeb2553d12acf94ef
>>
>> Aníbal Limón (8):
>>   toaster/tests: Reorder/move current test code.
>>   toaster/tests: Add __init__.py and base.py.
>>   toaster/tests: Improve ui.py module.
>>   toaster/tests: Adds setup test case.
>>   toaster/tests: Add helpers.py module.
>>   toaster-test: Refactor and imporvements.
>>   toaster/tests: Add README, TODO and requeriments.
>>   toaster/tests: Adds Copyright information.
>>
>>  bin/toaster-test                                   |  238 ++
>>  .../contrib/tts/toasteruitest/run_toastertests.py  |  155 --
>>  .../tts/toasteruitest/toaster_automation_test.py   | 2376 -------------------
>>  .../contrib/tts/toasteruitest/toaster_test.cfg     |   25 -
>>  lib/toaster/tests/README                           |   64 +
>>  lib/toaster/tests/TODO                             |   13 +
>>  lib/toaster/tests/__init__.py                      |    0
>>  lib/toaster/tests/base.py                          |   28 +
>>  lib/toaster/tests/helpers.py                       |  192 ++
>>  lib/toaster/tests/setup.py                         |   94 +
>>  lib/toaster/tests/toaster_test.cfg                 |   25 +
>>  lib/toaster/tests/ui.py                            | 2379 ++++++++++++++++++++
>>  toaster-tests-requirements.txt                     |    5 +
>>  13 files changed, 3038 insertions(+), 2556 deletions(-)
>>  create mode 100755 bin/toaster-test
>>  delete mode 100755 lib/toaster/contrib/tts/toasteruitest/run_toastertests.py
>>  delete mode 100755 lib/toaster/contrib/tts/toasteruitest/toaster_automation_test.py
>>  delete mode 100644 lib/toaster/contrib/tts/toasteruitest/toaster_test.cfg
>>  create mode 100644 lib/toaster/tests/README
>>  create mode 100644 lib/toaster/tests/TODO
>>  create mode 100644 lib/toaster/tests/__init__.py
>>  create mode 100644 lib/toaster/tests/base.py
>>  create mode 100755 lib/toaster/tests/helpers.py
>>  create mode 100644 lib/toaster/tests/setup.py
>>  create mode 100644 lib/toaster/tests/toaster_test.cfg
>>  create mode 100644 lib/toaster/tests/ui.py
>>  create mode 100644 toaster-tests-requirements.txt
>>
>> --
>> 2.1.4
>>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]