From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH v4 04/14] firmware/makefile: install BIOS blob ... Date: Fri, 18 Mar 2016 19:43:49 -0500 Message-ID: <56ECA0C5.6000809@cardoe.com> References: <1457978150-27201-1-git-send-email-anthony.perard@citrix.com> <1457978150-27201-5-git-send-email-anthony.perard@citrix.com> <56EAEB60.7040303@cardoe.com> <20160317183353.GI27408@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3279872821159783985==" Return-path: In-Reply-To: <20160317183353.GI27408@perard.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Anthony PERARD Cc: Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============3279872821159783985== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ug9wOLMUfSoJLBm95HmqnNikONwDsGRCE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ug9wOLMUfSoJLBm95HmqnNikONwDsGRCE Content-Type: multipart/mixed; boundary="EHwKVO2CEe3QctTeWbsXbBJl321KRl3Bh" From: Doug Goldstein To: Anthony PERARD Cc: xen-devel@lists.xen.org, Wei Liu , Ian Jackson , Stefano Stabellini Message-ID: <56ECA0C5.6000809@cardoe.com> Subject: Re: [Xen-devel] [PATCH v4 04/14] firmware/makefile: install BIOS blob ... References: <1457978150-27201-1-git-send-email-anthony.perard@citrix.com> <1457978150-27201-5-git-send-email-anthony.perard@citrix.com> <56EAEB60.7040303@cardoe.com> <20160317183353.GI27408@perard.uk.xensource.com> In-Reply-To: <20160317183353.GI27408@perard.uk.xensource.com> --EHwKVO2CEe3QctTeWbsXbBJl321KRl3Bh Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/17/16 1:33 PM, Anthony PERARD wrote: > On Thu, Mar 17, 2016 at 12:37:36PM -0500, Doug Goldstein wrote: >> On 3/14/16 12:55 PM, Anthony PERARD wrote: >>> ... into the firmware directory, along with hvmloader. >>> >>> Signed-off-by: Anthony PERARD >>> --- >>> Change in V4: >>> - remove install of acpi dsdt table >>> >>> Change in V3: >>> - do not check if ROMs file exist before installing, they should exis= t >>> - change rules for dsdt_anycpu_qemu_xen.c in oder to generate both .c= and >>> .aml files without changing temporarly the other dsdt_*.c rules. >>> --- >>> tools/firmware/Makefile | 13 +++++++++++++ >>> 1 file changed, 13 insertions(+) >>> >>> diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile >>> index 6cc86ce..6a37758 100644 >>> --- a/tools/firmware/Makefile >>> +++ b/tools/firmware/Makefile >>> @@ -19,6 +19,9 @@ SUBDIRS-y +=3D hvmloader >>> =20 >>> LD32BIT-$(CONFIG_FreeBSD) :=3D LD32BIT_FLAG=3D-melf_i386_fbsd >>> =20 >>> +SEABIOS_ROM :=3D seabios-dir/out/bios.bin >>> +OVMF_ROM :=3D ovmf-dir/ovmf.bin >>> + >>> ovmf-dir: >>> GIT=3D$(GIT) $(XEN_ROOT)/scripts/git-checkout.sh $(OVMF_UPSTREAM_UR= L) $(OVMF_UPSTREAM_REVISION) ovmf-dir >>> cp ovmf-makefile ovmf-dir/Makefile; >>> @@ -45,6 +48,16 @@ endif >>> install: all >>> [ -d $(INST_DIR) ] || $(INSTALL_DIR) $(INST_DIR) >>> [ ! -e $(TARGET) ] || $(INSTALL_DATA) $(TARGET) $(INST_DIR) >>> +ifeq ($(CONFIG_SEABIOS),y) >>> +ifeq ($(SEABIOS_PATH),) >>> + $(INSTALL_DATA) $(SEABIOS_ROM) $(INST_DIR)/seabios.bin >> >> Why install this as "seabios.bin" when the default is "bios.bin". Most= >> distro's packages for SeaBIOS install it as "bios.bin" >=20 > No reason. I guess it's fine to keep the same name ("bios.bin"). My dis= tro > install it as "bios-256k.bin", with "bios.bin" been the small version I= > guess. >=20 >=20 Right. All the distros should be doing that now for modern versions of SeaBIOS. When this work gets packaged up in a distro they'll likely use one of those two versions instead of using the one that Xen builds, like they mostly do with QEMU. I'd have to check how Xen builds SeaBIOS to know which it should point to. --=20 Doug Goldstein --EHwKVO2CEe3QctTeWbsXbBJl321KRl3Bh-- --ug9wOLMUfSoJLBm95HmqnNikONwDsGRCE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW7KDIXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUM3IQAIl0sxUApHi8bx0ryQ8g8p2U vhaXjC3KKJ7rpX4pUZqMpFDabprlfdzz+0iSepdx3+VQFWgL0C6ZnjvHXtvQOnaG LF/xjrUiSdIPvYilIEP8P2ziR4BqO/zy4ngMajyvk4c/4U9cYoGSx7VkxJzznZXX WknIZ+L+kLqp8ZPj9yc40Nqt2pLpHj9jIuOf9RIFjasEPuTyNuW/y02K+fRsIKmC 6IQIrhDNP7p5IjdsN/Vpks+Nl15Z29zSFRUjDrYpvMmeX2wjEeilHOOg1II3dBI0 A3oDbwlduiSb4M2DBFP/ZVyeWtjMggbP7nwbWfktJ4g7v5bZJYln3yEvSG0Th+7Z 7HhgoUB3y7rIsfQgJ8UEJgWQbCsbL3UZeTB9oRfMU/MwxU8Kk2xSspsZi/SKceIv Z0DqEZzZBoagk+jxXVj8EeLrcZTS09OeOWLJRoArJ8/838IbpB8S5fo28CzvEOSe dRpYA18neIMnLnQnIo3GDUceK9rSYxhuSzV8vkYUs42e8zZz6gH/XDJysUhFBMWd MNIfOwBh3aazg83Zht97LdpjFP3BHnjacV1Mxl4j/vWx2R4r7+zuVZICiNN7x4fl in9prhJkG3DOOFpCOpku/vQrnql2TAs8aVfAWHeJ7TTE1TumR9aYPylOjHZYVJ6F GZjMk+N2Ip7gNd7T1Pd9 =OG5x -----END PGP SIGNATURE----- --ug9wOLMUfSoJLBm95HmqnNikONwDsGRCE-- --===============3279872821159783985== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============3279872821159783985==--