From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH kvm-unit-tests 2/4] x86: vmx: fix vm{launch,resume} early exit logic Date: Sat, 19 Mar 2016 10:20:58 +0100 Message-ID: <56ED19FA.6010605@redhat.com> References: <56ED197A.3000702@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Peter Feiner , jan.kiszka@siemens.com, kvm@vger.kernel.org Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:32802 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608AbcCSJVC (ORCPT ); Sat, 19 Mar 2016 05:21:02 -0400 Received: by mail-wm0-f66.google.com with SMTP id x188so10752587wmg.0 for ; Sat, 19 Mar 2016 02:21:01 -0700 (PDT) In-Reply-To: <56ED197A.3000702@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 19/03/2016 10:18, Paolo Bonzini wrote: > > > On 18/03/2016 23:39, Peter Feiner wrote: >> If vmlaunch or vmresume returns immediately, there's definitely been >> an error -- rflags only needs to be consulted to determine what >> error occurred. By setting fail=1 unconditionally, the test framework >> will now detect problems with rflags *not* being set properly. > > You should still do the setbe, and follow it with orl $2, %0. Then if > fail==2 there is a problem. Nevermind, this is checked already below. Paolo