All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] serial: pl01x: Add support for devices with the rate pre-configured.
Date: Sun, 20 Mar 2016 00:06:08 -0600	[thread overview]
Message-ID: <56EE3DD0.5020300@wwwdotorg.org> (raw)
In-Reply-To: <56E8C6BB.8070805@wwwdotorg.org>

On 03/15/2016 08:36 PM, Stephen Warren wrote:
> On 03/13/2016 07:16 PM, Eric Anholt wrote:
>> For Raspberry Pi, we had the input clock rate to the pl011 fixed in
>> the rpi.c file, but it may be changed by firmware due to user changes
>> to config.txt.  Since the firmware always sets up the uart (default
>> 115200 output unless the user changes it), we can just skip our own
>> uart init to simplify the boot process and more reliably get serial
>> output.
>
> Tested-by: Stephen Warren <swarren@wwwdotorg.org>
> # on RPi B+ and RPi 2

Sorry, I take this Tested-by back. With the latest firmware (which has 
some modifications intended to initialize either the PL01x or the mini 
UART depending on which the kernel will actually use), this patch causes 
U-Boot not to boot at all. I'm pretty sure this is a FW bug (since even 
without this patch the UART doesn't work, but U-Boot does at least boot 
and can be used over HDMI/usbkbd), but I'd still prefer not to apply 
this until the FW is working again and we can double-check everything.

Hopefully this will be resolved in 
https://github.com/raspberrypi/firmware/issues/553 soon.

  reply	other threads:[~2016-03-20  6:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  1:16 [U-Boot] [PATCH v2] serial: pl01x: Add support for devices with the rate pre-configured Eric Anholt
2016-03-14 15:25 ` Tom Rini
2016-03-16  2:36 ` Stephen Warren
2016-03-20  6:06   ` Stephen Warren [this message]
2016-03-22  2:11     ` Stephen Warren
2016-03-23  1:59 ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EE3DD0.5020300@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.