From: Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>
To: Karol Herbst <nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 04/19] clk: print the base clocks
Date: Sun, 20 Mar 2016 19:16:01 +0200 [thread overview]
Message-ID: <56EEDAD1.6040208@free.fr> (raw)
In-Reply-To: <1458255836-3878-5-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
On 18/03/16 01:03, Karol Herbst wrote:
> Signed-off-by: Karol Herbst <nouveau@karolherbst.de>
> ---
> drm/nouveau/nvkm/subdev/clk/base.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drm/nouveau/nvkm/subdev/clk/base.c b/drm/nouveau/nvkm/subdev/clk/base.c
> index 889cce2..4928668 100644
> --- a/drm/nouveau/nvkm/subdev/clk/base.c
> +++ b/drm/nouveau/nvkm/subdev/clk/base.c
> @@ -24,6 +24,7 @@
> #include "priv.h"
>
> #include <subdev/bios.h>
> +#include <subdev/bios/baseclock.h>
> #include <subdev/bios/boost.h>
> #include <subdev/bios/cstep.h>
> #include <subdev/bios/perf.h>
> @@ -561,10 +562,24 @@ int
> nvkm_clk_ctor(const struct nvkm_clk_func *func, struct nvkm_device *device,
> int index, bool allow_reclock, struct nvkm_clk *clk)
> {
> + struct nvkm_subdev *subdev = &clk->subdev;
> + struct nvkm_bios *bios = device->bios;
> int ret, idx, arglen;
> const char *mode;
> + struct nvbios_baseclk_header h;
> +
> + nvkm_subdev_ctor(&nvkm_clk, device, index, 0, subdev);
> +
> + if (bios && !nvbios_baseclock_parse(bios, &h)) {
> + struct nvbios_baseclk_entry base, boost;
> + if (!nvbios_baseclock_entry(bios, &h, h.boost, &boost))
> + nvkm_info(subdev, "boost: %i MHz\n",
> + boost.clock_mhz / 2);
> + if (!nvbios_baseclock_entry(bios, &h, h.base, &base))
> + nvkm_info(subdev, "base: %i MHz\n",
> + base.clock_mhz / 2);
> + }
>
> - nvkm_subdev_ctor(&nvkm_clk, device, index, 0, &clk->subdev);
> clk->func = func;
> INIT_LIST_HEAD(&clk->states);
> clk->domains = func->domains;
>
I would rather have you report this information in debugfs, if you don't
mind.
This is really out of place, especially since we do not show the clocks
anymore apparently.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2016-03-20 17:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 23:03 [PATCH 00/19] Volting/Clocking improvements for Fermi and newer Karol Herbst
[not found] ` <1458255836-3878-1-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-03-17 23:03 ` [PATCH 01/19] bios/volt: handle voltage table version 0x50 with 0ed header Karol Herbst
2016-03-17 23:03 ` [PATCH 02/19] volt: properly detect entry based voltage tables Karol Herbst
2016-03-17 23:03 ` [PATCH 03/19] bios: add parsing of BASE CLOCK table Karol Herbst
[not found] ` <1458255836-3878-4-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-03-20 17:07 ` Martin Peres
2016-03-17 23:03 ` [PATCH 04/19] clk: print the base clocks Karol Herbst
[not found] ` <1458255836-3878-5-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-03-20 17:16 ` Martin Peres [this message]
2016-03-17 23:03 ` [PATCH 05/19] clk: allow boosting only when NvBoost is set Karol Herbst
[not found] ` <1458255836-3878-6-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-03-20 20:15 ` Martin Peres
2016-03-17 23:03 ` [PATCH 06/19] volt: save the voltage range we are able to set Karol Herbst
2016-03-17 23:03 ` [PATCH 07/19] volt: add nvkm_volt_map_min function Karol Herbst
2016-03-17 23:03 ` [PATCH 08/19] clk: don't create cstates which voltage is higher than what the gpu can do Karol Herbst
2016-03-17 23:03 ` [PATCH 09/19] volt: parse the both max voltage entries Karol Herbst
2016-03-17 23:03 ` [PATCH 10/19] volt: add min_id parameter to nvkm_volt_set_id Karol Herbst
2016-03-17 23:03 ` [PATCH 11/19] clk: export nvkm_volt_map Karol Herbst
2016-03-17 23:03 ` [PATCH 12/19] clk: add index field to nvkm_cstate Karol Herbst
2016-03-17 23:03 ` [PATCH 13/19] add daemon to compare nouveau with blob voltage Karol Herbst
2016-03-17 23:03 ` [PATCH 14/19] volt: add temperature parameter to nvkm_volt_map Karol Herbst
2016-03-17 23:03 ` [PATCH 15/19] nouveau/subdev/clk: fixup cstate selection Karol Herbst
2016-03-17 23:03 ` [PATCH 16/19] clk: respect voltage limits in nvkm_cstate_prog with cstate = -1 Karol Herbst
2016-03-17 23:03 ` [PATCH 17/19] volt: don't require perfect fit Karol Herbst
2016-03-17 23:03 ` [PATCH 18/19] bios/vmap: unk0 field is the mode Karol Herbst
2016-03-17 23:03 ` [PATCH 19/19] volt: add coefficients I found on my gpu Karol Herbst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EEDAD1.6040208@free.fr \
--to=martin.peres-ganu6spqydw@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.