From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCHv13 01/17] dts: exynos4*: add HDMI CEC pin definition to pinctrl Date: Mon, 21 Mar 2016 09:22:46 +0900 Message-ID: <56EF3ED6.3010308@samsung.com> References: <1458310036-19252-1-git-send-email-hans.verkuil@cisco.com> <1458310036-19252-2-git-send-email-hans.verkuil@cisco.com> <20160319025040.GA7289@kozik-lap> <56ED0AA3.1000601@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <56ED0AA3.1000601@xs4all.nl> Sender: linux-media-owner@vger.kernel.org To: Hans Verkuil , Hans Verkuil Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-input@vger.kernel.org, lars@opdenkamp.eu, linux@arm.linux.org.uk, Kamil Debski , krzk@kernel.org List-Id: linux-input@vger.kernel.org On 19.03.2016 17:15, Hans Verkuil wrote: > On 03/19/2016 03:50 AM, Krzysztof Kozlowski wrote: >> On Fri, Mar 18, 2016 at 03:07:00PM +0100, Hans Verkuil wrote: >>> From: Kamil Debski >>> >>> Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and >>> Exynos4x12 SoCs. These are required by the HDMI CEC device. >>> >>> Signed-off-by: Kamil Debski >>> Signed-off-by: Hans Verkuil >>> Acked-by: Krzysztof Kozlowski >>> --- >>> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 7 +++++++ >>> arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 7 +++++++ >>> 2 files changed, 14 insertions(+) >> >> Hi Hans, >> >> I see you have been carrying these three patches for a long time. >> Initially I thought that there are some dependencies... but maybe there >> are not? >> >> Can I take these Exynos DTS patches to samsung-soc? > > That would be very nice! I'll apply them after merge window. > BTW, it would be nice if someone from Samsung could try to improve the s5p > CEC driver from this patch series. > > The problem is that it expects userspace to tell it the physical address, > which is read from the EDID. But the HDMI driver in the kernel already knows > this, so requiring userspace to handle this is not nice. > > Basically the CEC driver needs to know when a new EDID has been read and > when the hotplug detect goes low (EDID has been lost). > > If someone who actually knows the HDMI code could provide me with a patch, > then I can fix the CEC driver. I have an odroid to test with, so I can check > the code. Not quite my area of knowledge but I'll keep it in mind. Best regards, Krzysztof