From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahtH8-000153-1O for qemu-devel@nongnu.org; Mon, 21 Mar 2016 02:25:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahtH4-0000g1-Rj for qemu-devel@nongnu.org; Mon, 21 Mar 2016 02:25:13 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:35414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahtH4-0000fg-Ka for qemu-devel@nongnu.org; Mon, 21 Mar 2016 02:25:10 -0400 Received: by mail-pf0-x241.google.com with SMTP id u190so28581349pfb.2 for ; Sun, 20 Mar 2016 23:25:10 -0700 (PDT) References: <1458011856-44711-1-git-send-email-aik@ozlabs.ru> From: Alexey Kardashevskiy Message-ID: <56EF93C0.6010104@ozlabs.ru> Date: Mon, 21 Mar 2016 17:25:04 +1100 MIME-Version: 1.0 In-Reply-To: <1458011856-44711-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu] vmstate: Define VARRAY with VMS_ALLOC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: David Gibson , Juan Quintela On 03/15/2016 02:17 PM, Alexey Kardashevskiy wrote: > This allows dynamic allocation for migrating arrays. > > Already existing VMSTATE_VARRAY_UINT32 requires an array to be > pre-allocated, however there are cases when the size is not known in > advance and there is no real need to enforce it. > > This defines another variant of VMSTATE_VARRAY_UINT32 with WMS_ALLOC > flag which tells the receiving side to allocate memory for the array > before receiving the data. > > The first user of it is the "pseries" machine (POWER8) with > dynamic DMA windows which existence and size are totally dynamic. > > Signed-off-by: Alexey Kardashevskiy > Reviewed-by: David Gibson > Reviewed-by: Thomas Huth > --- > > > As David suggested, I am posting it alone (separately from the DDW patchset). > > It would be nice either to get "ack" to get this pulled via the powerpc > tree or get it pulled to the upstream via some other tree. Thanks! So what is about this patch? Ack, nack? Thanks! > > > --- > include/migration/vmstate.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > index 84ee355..1622638 100644 > --- a/include/migration/vmstate.h > +++ b/include/migration/vmstate.h > @@ -386,6 +386,16 @@ extern const VMStateInfo vmstate_info_bitmap; > .offset = vmstate_offset_pointer(_state, _field, _type), \ > } > > +#define VMSTATE_VARRAY_UINT32_ALLOC(_field, _state, _field_num, _version, _info, _type) {\ > + .name = (stringify(_field)), \ > + .version_id = (_version), \ > + .num_offset = vmstate_offset_value(_state, _field_num, uint32_t),\ > + .info = &(_info), \ > + .size = sizeof(_type), \ > + .flags = VMS_VARRAY_UINT32|VMS_POINTER|VMS_ALLOC, \ > + .offset = vmstate_offset_pointer(_state, _field, _type), \ > +} > + > #define VMSTATE_VARRAY_UINT16_UNSAFE(_field, _state, _field_num, _version, _info, _type) {\ > .name = (stringify(_field)), \ > .version_id = (_version), \ > -- Alexey