From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH 0/5] lpm allocation fixes - v3 Date: Mon, 21 Mar 2016 14:18:54 +0100 Message-ID: <56EFF4BE.3070001@6wind.com> References: <1458137793-25826-1-git-send-email-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon To: Christian Ehrhardt , bruce.richardson@intel.com, dev@dpdk.org Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id BF6802BF3 for ; Mon, 21 Mar 2016 14:18:56 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id r129so50117851wmr.1 for ; Mon, 21 Mar 2016 06:18:56 -0700 (PDT) In-Reply-To: <1458137793-25826-1-git-send-email-christian.ehrhardt@canonical.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/16/2016 03:16 PM, Christian Ehrhardt wrote: > Poking a bit on autotest revealed a few shortcomings in the lpm allocation path. > Thanks to the feedback to the first revision of the patches here v2. > Also Oliver Matz spotted similar issues and made me aware - thanks! > Integrating them revealed even more use after free / leak issues. > > *updates in v3* > - lpm create/free path for v20 and v1604 got the same fixes that were > already identified for lpm6 before > > *updates in v2* > - lpm/lpm6 patches split > - following dpdk coding guidelines regarding single line if's > - adding singed-off and acked-bys gathered so far > - combine all three related patches in one series > > [PATCH 1/5] lpm6: fix use after free of lpm in rte_lpm6_create > [PATCH 2/5] lpm6: fix missing free of rules_tbl and lpm > [PATCH 3/5] lpm: fix missing free of lpm > [PATCH 4/5] lpm: fix use after free of lpm in rte_lpm_create* > [PATCH 5/5] lpm: fix missing free of rules_tbl and lpm in > > diffstat: > rte_lpm.c | 23 ++++++++++------------- > rte_lpm6.c | 12 ++++++------ > 2 files changed, 16 insertions(+), 19 deletions(-) > Series Acked-by: Olivier Matz Just one small comment: there are additional { } in patches 2/5 and 3/5. Thomas, do you think you can remove it while pushing?