From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 5/6] virt, sched: add cpu pinning to
	smp_call_sync_on_phys_cpu()
Date: Mon, 21 Mar 2016 14:14:03 +0000
Message-ID: <56F001AB.2000600@citrix.com>
References: <1458563075-30298-1-git-send-email-jgross@suse.com>
	<1458563075-30298-6-git-send-email-jgross@suse.com>
	<56F0087202000078000DED9F@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <virtualization-bounces@lists.linux-foundation.org>
In-Reply-To: <56F0087202000078000DED9F@prv-mh.provo.novell.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
To: Jan Beulich <JBeulich@suse.com>, Juergen Gross <JGross@suse.com>
Cc: jeremy@goop.org, hpa@zytor.com, peterz@infradead.org, x86@kernel.org, akataria@vmware.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, chrisw@sous-sol.org, Jean Delvare <jdelvare@suse.com>, mingo@redhat.com, Douglas_Warzecha@dell.com, pali.rohar@gmail.com, xen-devel@lists.xenproject.org, tglx@linutronix.de, boris.ostrovsky@oracle.com, linux@roeck-us.net
List-Id: virtualization@lists.linuxfoundation.org

On 21/03/16 13:42, Jan Beulich wrote:
>
> Also don't you need to call smp_processor_id() after preempt_disable()?

I suggest using get_cpu()/put_cpu() here.

David

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756262AbcCUOOS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Mar 2016 10:14:18 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:3948 "EHLO SMTP02.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755215AbcCUOON (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Mar 2016 10:14:13 -0400
X-IronPort-AV: E=Sophos;i="5.24,372,1454976000"; 
   d="scan'208";a="347399896"
Subject: Re: [Xen-devel] [PATCH v2 5/6] virt, sched: add cpu pinning to
 smp_call_sync_on_phys_cpu()
To: Jan Beulich <JBeulich@suse.com>, Juergen Gross <JGross@suse.com>
References: <1458563075-30298-1-git-send-email-jgross@suse.com>
 <1458563075-30298-6-git-send-email-jgross@suse.com>
 <56F0087202000078000DED9F@prv-mh.provo.novell.com>
CC: <Douglas_Warzecha@dell.com>, <pali.rohar@gmail.com>, <jeremy@goop.org>,
        <peterz@infradead.org>, <x86@kernel.org>, <tglx@linutronix.de>,
        <virtualization@lists.linux-foundation.org>,
        <xen-devel@lists.xenproject.org>, <boris.ostrovsky@oracle.com>,
        <mingo@redhat.com>, <linux@roeck-us.net>, <rusty@rustcorp.com.au>,
        <chrisw@sous-sol.org>, Jean Delvare <jdelvare@suse.com>,
        <linux-kernel@vger.kernel.org>, <akataria@vmware.com>, <hpa@zytor.com>
From: David Vrabel <david.vrabel@citrix.com>
X-Enigmail-Draft-Status: N1110
Message-ID: <56F001AB.2000600@citrix.com>
Date: Mon, 21 Mar 2016 14:14:03 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <56F0087202000078000DED9F@prv-mh.provo.novell.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21/03/16 13:42, Jan Beulich wrote:
>
> Also don't you need to call smp_processor_id() after preempt_disable()?

I suggest using get_cpu()/put_cpu() here.

David