From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Joao Martins <joao.m.martins@oracle.com>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 1/5] public/xen.h: add flags field to vcpu_time_info
Date: Mon, 21 Mar 2016 15:27:29 +0000 [thread overview]
Message-ID: <56F012E1.3080108@citrix.com> (raw)
In-Reply-To: <56F01CE502000078000DEE6A@prv-mh.provo.novell.com>
On 21/03/16 15:10, Jan Beulich wrote:
>>>> On 17.03.16 at 17:12, <joao.m.martins@oracle.com> wrote:
>> --- a/xen/include/public/xen.h
>> +++ b/xen/include/public/xen.h
>> @@ -614,10 +614,14 @@ struct vcpu_time_info {
>> */
>> uint32_t tsc_to_system_mul;
>> int8_t tsc_shift;
>> - int8_t pad1[3];
>> + int8_t flags;
> For use as flags I'm sure this would better be uint8_t.
Sadly not possible. Linux have already made the above adjustment
without (CC'ing xen-devel), so that ABI is set.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-21 15:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 16:12 [PATCH 0/5] x86/time: PVCLOCK_TSC_STABLE_BIT support Joao Martins
2016-03-17 16:12 ` [PATCH 1/5] public/xen.h: add flags field to vcpu_time_info Joao Martins
2016-03-18 20:12 ` Andrew Cooper
2016-03-21 11:42 ` Joao Martins
2016-03-21 11:43 ` Andrew Cooper
2016-03-21 11:51 ` Joao Martins
2016-03-21 15:10 ` Jan Beulich
2016-03-21 15:27 ` Andrew Cooper [this message]
2016-03-21 15:40 ` Joao Martins
2016-03-17 16:12 ` [PATCH 2/5] x86/time: implement tsc as clocksource Joao Martins
2016-03-18 20:21 ` Andrew Cooper
2016-03-21 11:43 ` Joao Martins
2016-03-22 12:41 ` Joao Martins
2016-03-22 12:46 ` Jan Beulich
2016-03-22 15:51 ` Joao Martins
2016-03-22 16:02 ` Jan Beulich
2016-03-22 20:40 ` Joao Martins
2016-03-23 7:28 ` Jan Beulich
2016-03-23 12:05 ` Joao Martins
2016-03-23 14:05 ` Jan Beulich
2016-03-17 16:12 ` [PATCH 3/5] x86/time: streamline platform time init on plt_init() Joao Martins
2016-03-18 20:32 ` Andrew Cooper
2016-03-21 11:45 ` Joao Martins
2016-03-17 16:12 ` [PATCH 4/5] x86/time: refactor read_platform_stime() Joao Martins
2016-03-18 20:34 ` Andrew Cooper
2016-03-21 11:45 ` Joao Martins
2016-03-21 13:08 ` Andrew Cooper
2016-03-17 16:12 ` [PATCH 5/5] x86/time: implement PVCLOCK_TSC_STABLE_BIT Joao Martins
2016-03-18 20:58 ` Andrew Cooper
2016-03-21 11:50 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F012E1.3080108@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=joao.m.martins@oracle.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.