From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH 2/6] drm/i915: Allow passing any known
 pointer to for_each_engine()
Date: Mon, 21 Mar 2016 15:44:27 +0000
Message-ID: <56F016DB.8010907@intel.com>
References: <1458335784-1773-1-git-send-email-chris@chris-wilson.co.uk>
 <1458335784-1773-2-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 8A5B06E063
 for <intel-gfx@lists.freedesktop.org>; Mon, 21 Mar 2016 15:44:29 +0000 (UTC)
In-Reply-To: <1458335784-1773-2-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMTgvMDMvMTYgMjE6MTYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBSYXRoZXIgdGhhbiByZXF1
aXJlIHRoZSB1c2VyIHRvIGdyYWIgYSBkcm1faTkxNV9wcml2YXRlLCBhbGxvdyB0aGVtIHRvCj4g
cGFzcyBhbnl0aGluZyB0aGF0IHdlIGtub3cgaG93IHRvIGRlcml2ZSBzdWNoIGEgcG9pbnRlciB1
c2VyIHRvX2k5MTUoKQo+Cj4gTm90ZSB0aGlzIGZpeGVzIGEgbWFjcm8gYnVnIGluIGZvcl9lYWNo
X2VuZ2luZV9tYXNrZWQoKSB3aGljaCB3YXMgbm90Cj4gdXNpbmcgaXRzIGRldl9wcml2X18gcGFy
YW1ldGVyLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz
b24uY28udWs+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwu
Y29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgIHwg
OCArKysrLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jIHwg
NCArKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9tb2NzLmMgICAgICAgfCAzICst
LQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpI
bW0gLi4gZ2VuZXJhbGx5IEknbSBxdWl0ZSBrZWVuIG9uIGVuaGFuY2luZyB0b19pOTE1KCksIGJ1
dCBJJ20gbm90IHN1cmUgCmFib3V0IHRoaXMgaXRlcmF0b3IuIFRoZSB0aGluZyBpcywgdGhhdCB0
aGUgYXJyYXkgb2YgZW5naW5lcyBhcmUgCmFzc29jaWF0ZWQgd2l0aCB0aGUgZGV2aWNlIChvciBk
ZXZfcHJpdi9pOTE1KSBhcyBhIHdob2xlLCBhbmQgbm90IHdpdGggCmFuIG9iamVjdCAoZXRjKS4g
SW4gcGFydGljdWxhciwgc29tZSBvYmplY3RzIGNhbiBoYXZlIGFzc29jaWF0aW9ucyB3aXRoIApv
bmUgb3IgbW9yZSBzcGVjaWZpYyBlbmdpbmVzLCBlaXRoZXIgcGVybWFuZW50bHkgKGUuZy4gdGhl
IGtlcm5lbCAKY29udGV4dCBzdWJvYmplY3RzKSBvciB0cmFuc2llbnRseSAob2JqZWN0cyBiZWlu
ZyB1c2VkIGJ5IHdvcmtsb2FkcykuIEl0IAp0aGVyZWZvcmUgc2VlbXMgY291bnRlcmludHVpdGl2
ZSB0byB1c2Ugc3VjaCBhbiBvYmplY3QgYXMgdGhlIGJhc2lzIGZvciAKaXRlcmF0aW5nIG92ZXIg
YWxsIChpbml0aWFsaXNlZCkgZW5naW5lczsgSSBtaWdodCBqdXN0IGFzIHJlYXNvbmFibHkgCmV4
cGVjdCB0aGUgbWFjcm8gdG8gaXRlcmF0ZSBvdmVyIGFsbCAoYnV0IG9ubHkpIHRoZSBlbmdpbmVz
IGFzc29jaWF0ZWQgCndpdGggdGhlIG9iamVjdCAod2hhdGV2ZXIgdGhhdCBtaWdodCBtZWFuIGlu
IGEgcGFydGljdWxhciBjYXNlKS4KClNvIEkgdGhpbmsgZm9yX2VhY2hfZW5naW5lKCkgc2hvdWxk
IGNvbnRpbnVlIHRvIHJlcXVpcmUgdGhlIGNhbGxlciB0byAKcHJvdmlkZSBhIChzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZSAqKSBzbyB0aGF0IGl0J3MgY2xlYXIgdGhhdCB3ZSdyZSAKb3BlcmF0aW5n
IG9uIHRoZSB3aG9sZSBkZXZpY2UuIEJ1dCB0aGUgcGFydGlhbGx5IHNpbXBsaWZpY2F0aW9uIG9m
IAphbGxvd2luZyB0b19pOTE1KGVuZ2luZSkgcmF0aGVyIHRoYW4gdG9faTkxNShlbmdpbmUtPmRl
dikgaXMgZmluZS4gQW5kIApvZiBjb3Vyc2Ugd2Ugc3RpbGwgd2FudCB0aGUgYnVnIGZpeCEKCj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggODYwNmUyYzdkYjA0Li4wYzlmZTAwZDNlODMg
MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMTk4OCwxMiArMTk4OCwxMiBAQCBz
dGF0aWMgaW5saW5lIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpndWNfdG9faTkxNShzdHJ1Y3Qg
aW50ZWxfZ3VjICpndWMpCj4gICB9Cj4KPiAgIC8qIEl0ZXJhdGUgb3ZlciBpbml0aWFsaXNlZCBy
aW5ncyAqLwo+IC0jZGVmaW5lIGZvcl9lYWNoX2VuZ2luZShyaW5nX18sIGRldl9wcml2X18sIGlf
XykgXAo+ICsjZGVmaW5lIGZvcl9lYWNoX2VuZ2luZShyaW5nX18sIHB0cl9fLCBpX18pIFwKPiAg
IAlmb3IgKChpX18pID0gMDsgKGlfXykgPCBJOTE1X05VTV9FTkdJTkVTOyAoaV9fKSsrKSBcCj4g
LQkJZm9yX2VhY2hfaWYgKCgoKHJpbmdfXykgPSAmKGRldl9wcml2X18pLT5lbmdpbmVbKGlfXyld
KSwgaW50ZWxfZW5naW5lX2luaXRpYWxpemVkKChyaW5nX18pKSkpCj4gKwkJZm9yX2VhY2hfaWYg
KCgoKHJpbmdfXykgPSAmdG9faTkxNShwdHJfXyktPmVuZ2luZVsoaV9fKV0pLCBpbnRlbF9lbmdp
bmVfaW5pdGlhbGl6ZWQoKHJpbmdfXykpKSkKPgo+IC0jZGVmaW5lIGZvcl9lYWNoX2VuZ2luZV9t
YXNrZWQoZW5naW5lX18sIGRldl9wcml2X18sIG1hc2tfXykgXAo+IC0JZm9yICgoZW5naW5lX18p
ID0gJmRldl9wcml2LT5lbmdpbmVbMF07IChlbmdpbmVfXykgPCAmZGV2X3ByaXYtPmVuZ2luZVtJ
OTE1X05VTV9FTkdJTkVTXTsgKGVuZ2luZV9fKSsrKSBcCj4gKyNkZWZpbmUgZm9yX2VhY2hfZW5n
aW5lX21hc2tlZChlbmdpbmVfXywgcHRyX18sIG1hc2tfXykgXAo+ICsJZm9yICgoZW5naW5lX18p
ID0gJnRvX2k5MTUocHRyX18pLT5lbmdpbmVbMF07IChlbmdpbmVfXykgPCAmdG9faTkxNShwdHJf
XyktPmVuZ2luZVtJOTE1X05VTV9FTkdJTkVTXTsgKGVuZ2luZV9fKSsrKSBcCj4gICAJCWZvcl9l
YWNoX2lmIChpbnRlbF9lbmdpbmVfZmxhZygoZW5naW5lX18pKSAmIChtYXNrX18pICYmIGludGVs
X2VuZ2luZV9pbml0aWFsaXplZCgoZW5naW5lX18pKSkKPgo+ICAgZW51bSBoZG1pX2ZvcmNlX2F1
ZGlvIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4
dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jCj4gaW5kZXggMzk0
ZTUyNWU1NWYxLi5hOGFmZDBjZWU3ZjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9nZW1fY29udGV4dC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n
ZW1fY29udGV4dC5jCj4gQEAgLTU1Myw3ICs1NTMsNyBAQCBtaV9zZXRfY29udGV4dChzdHJ1Y3Qg
ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwgdTMyIGh3X2ZsYWdzKQo+Cj4gICAJCQlpbnRlbF9y
aW5nX2VtaXQoZW5naW5lLAo+ICAgCQkJCQlNSV9MT0FEX1JFR0lTVEVSX0lNTShudW1fcmluZ3Mp
KTsKPiAtCQkJZm9yX2VhY2hfZW5naW5lKHNpZ25hbGxlciwgdG9faTkxNShlbmdpbmUtPmRldiks
IGkpIHsKPiArCQkJZm9yX2VhY2hfZW5naW5lKHNpZ25hbGxlciwgZW5naW5lLT5kZXYsIGkpIHsK
CmZvcl9lYWNoX2VuZ2luZShzaWduYWxsZXIsIHRvX2k5MTUoZW5naW5lKSwgaSkgPwoKPiAgIAkJ
CQlpZiAoc2lnbmFsbGVyID09IGVuZ2luZSkKPiAgIAkJCQkJY29udGludWU7Cj4KPiBAQCAtNTgy
LDcgKzU4Miw3IEBAIG1pX3NldF9jb250ZXh0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAq
cmVxLCB1MzIgaHdfZmxhZ3MpCj4KPiAgIAkJCWludGVsX3JpbmdfZW1pdChlbmdpbmUsCj4gICAJ
CQkJCU1JX0xPQURfUkVHSVNURVJfSU1NKG51bV9yaW5ncykpOwo+IC0JCQlmb3JfZWFjaF9lbmdp
bmUoc2lnbmFsbGVyLCB0b19pOTE1KGVuZ2luZS0+ZGV2KSwgaSkgewo+ICsJCQlmb3JfZWFjaF9l
bmdpbmUoc2lnbmFsbGVyLCBlbmdpbmUtPmRldiwgaSkgewoKQWxzbyBmb3JfZWFjaF9lbmdpbmUo
c2lnbmFsbGVyLCB0b19pOTE1KGVuZ2luZSksIGkpCgo+ICAgCQkJCWlmIChzaWduYWxsZXIgPT0g
ZW5naW5lKQo+ICAgCQkJCQljb250aW51ZTsKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9tb2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9tb2NzLmMK
PiBpbmRleCAzYzcyNWRkZTE2ZWQuLjQ1MjAwYjkzZTliYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9tb2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9tb2NzLmMKPiBAQCAtMzIzLDEyICszMjMsMTEgQEAgaW50IGludGVsX3Jjc19jb250ZXh0
X2luaXRfbW9jcyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSkKPiAgIAlpbnQgcmV0
Owo+Cj4gICAJaWYgKGdldF9tb2NzX3NldHRpbmdzKHJlcS0+ZW5naW5lLT5kZXYsICZ0KSkgewo+
IC0JCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJlcS0+aTkxNTsKPiAgIAkJ
c3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+ICAgCQllbnVtIGludGVsX2VuZ2luZV9p
ZCByaW5nX2lkOwo+Cj4gICAJCS8qIFByb2dyYW0gdGhlIGNvbnRyb2wgcmVnaXN0ZXJzICovCj4g
LQkJZm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgZGV2X3ByaXYsIHJpbmdfaWQpIHsKPiArCQlmb3Jf
ZWFjaF9lbmdpbmUoZW5naW5lLCByZXEtPmk5MTUsIHJpbmdfaWQpIHsKCkknbSBxdWl0ZSBoYXBw
eSB3aXRoIHRoaXMgb25lIDopCgouRGF2ZS4KCj4gICAJCQlyZXQgPSBlbWl0X21vY3NfY29udHJv
bF90YWJsZShyZXEsICZ0LCByaW5nX2lkKTsKPiAgIAkJCWlmIChyZXQpCj4gICAJCQkJcmV0dXJu
IHJldDsKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0
dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==