From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time
Date: Mon, 21 Mar 2016 17:21:30 +0100 [thread overview]
Message-ID: <56F01F8A.2090902@redhat.com> (raw)
In-Reply-To: <87k2kvzu0z.fsf@blackfin.pond.sub.org>
On 21/03/2016 17:15, Markus Armbruster wrote:
> * Explicitly with x-blockdev-del
>
> Fails unless no other reference exists. Where is the legacy_dinfo
> released?
Can a -drive block device be deleted with x-blockdev-del even?!?
In other words, you said "This looks like DriveInfo now owns a reference
to BlockBackend, even though the pointer still goes in the other
direction". I say, "I thought this was the idea all along"...
Shall I add a check to x-blockdev-del that gives an error if the
BlockBackend has a DriveInfo attached?
Paolo
> * Implicitly via warty automatic deletion
>
> Your PATCH 01 has the necessary replacement of blk_unref(blk) by
> blkdev_del_drive(blk) for some devices (virtio-blk.c, scsi-bus.c,
> xen_disk,c, piix.c), butas far as I can see not for others such as
> nvme.c.
next prev parent reply other threads:[~2016-03-21 16:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 14:39 [Qemu-devel] [PATCH 0/3] Early release of -drive QemuOpts Paolo Bonzini
2016-02-22 14:39 ` [Qemu-devel] [PATCH 1/3] block: detach devices from DriveInfo at unrealize time Paolo Bonzini
2016-03-21 15:13 ` Markus Armbruster
2016-03-21 15:31 ` Paolo Bonzini
2016-03-21 17:19 ` Markus Armbruster
2016-03-21 17:30 ` Paolo Bonzini
2016-03-23 8:35 ` Markus Armbruster
2016-03-23 9:35 ` Paolo Bonzini
2016-03-22 22:15 ` Paolo Bonzini
2016-02-22 14:39 ` [Qemu-devel] [PATCH 2/3] block: keep BlockBackend alive until device finalize time Paolo Bonzini
2016-03-21 15:22 ` Markus Armbruster
2016-03-21 15:37 ` Paolo Bonzini
2016-02-22 14:39 ` [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time Paolo Bonzini
2016-03-21 16:15 ` Markus Armbruster
2016-03-21 16:21 ` Paolo Bonzini [this message]
2016-03-21 17:30 ` Markus Armbruster
2016-03-21 17:34 ` Paolo Bonzini
2016-03-21 18:14 ` Markus Armbruster
2016-03-22 8:19 ` Kevin Wolf
2016-03-22 10:25 ` Markus Armbruster
2016-03-22 22:07 ` Paolo Bonzini
2016-03-23 9:18 ` Markus Armbruster
2016-03-23 9:40 ` Paolo Bonzini
2016-03-23 12:13 ` Markus Armbruster
2016-03-21 17:39 ` Kevin Wolf
2016-03-21 18:02 ` Markus Armbruster
2016-03-22 22:10 ` Paolo Bonzini
2016-03-23 8:37 ` Markus Armbruster
2016-03-09 12:20 ` [Qemu-devel] [PATCH 0/3] Early release of -drive QemuOpts Paolo Bonzini
2016-03-09 12:30 ` Kevin Wolf
2016-03-09 12:53 ` Markus Armbruster
2016-03-17 17:00 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F01F8A.2090902@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.