From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH] dbus: Replace copy_params/size_params with macros.
Date: Mon, 21 Mar 2016 11:42:16 -0500 [thread overview]
Message-ID: <56F02468.3090100@gmail.com> (raw)
In-Reply-To: <1458367247-14607-2-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
Hi Andrew,
On 03/19/2016 01:00 AM, Andrew Zaborowski wrote:
> Passing va_list to functions this way doesn't work on i386 gcc, va_list
> seems to be a simple pointer as recommended by stdarg(3). Passing a
> pointer to va_list seems to fix this, but stdarg(3) also says:
>
> If ap is passed to a function that uses va_arg(ap,type), then the value
> of ap is undefined after the return of that function.
>
> so it's better to just use a macro.
> ---
> ell/dbus-service.c | 98 ++++++++++++++++++++++--------------------------------
> 1 file changed, 40 insertions(+), 58 deletions(-)
Makes sense to me. Thanks for looking into this one.
Applied, thanks.
Regards,
-Denis
next prev parent reply other threads:[~2016-03-21 16:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 6:00 [PATCH] dbus: More complete buffer size check in dbus_message_from_blob Andrew Zaborowski
2016-03-19 6:00 ` [PATCH] dbus: Replace copy_params/size_params with macros Andrew Zaborowski
2016-03-21 16:42 ` Denis Kenzior [this message]
2016-03-19 6:00 ` [PATCH] unit: Add int64_t casts in dbus tests failing on i386 Andrew Zaborowski
2016-03-21 16:44 ` Denis Kenzior
2016-03-19 6:00 ` [PATCH] dbus: Take iter->sig_len into account in l_dbus_message_iter_get_variant Andrew Zaborowski
2016-03-21 16:59 ` Denis Kenzior
2016-03-19 6:00 ` [PATCH] gvariant: Exclude container's offsets from child iterator len Andrew Zaborowski
2016-03-21 17:57 ` Denis Kenzior
2016-03-21 22:09 ` Andrzej Zaborowski
2016-03-19 6:00 ` [PATCH] gvariant: Reset container's variable_is_last for fixed-size structs Andrew Zaborowski
2016-03-21 18:05 ` Denis Kenzior
2016-03-19 6:00 ` [PATCH] dbus: Fix returned body_size in _dbus1_builder_finish Andrew Zaborowski
2016-03-21 17:02 ` Denis Kenzior
2016-03-19 6:00 ` [PATCH 1/2] dbus: Add _gvariant_builder_mark and _rewind Andrew Zaborowski
2016-03-21 18:05 ` Denis Kenzior
2016-03-19 6:00 ` [PATCH 2/2] unit: reuse mark+rewind, complex 1 tests for gvariant-message Andrew Zaborowski
2016-03-21 18:06 ` Denis Kenzior
2016-03-21 17:16 ` [PATCH] dbus: More complete buffer size check in dbus_message_from_blob Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F02468.3090100@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.