From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis de Bethencourt Subject: Re: [PATCH] net: Add missing kernel-doc for netdev ptype lists Date: Mon, 21 Mar 2016 21:47:37 +0000 Message-ID: <56F06BF9.6010004@osg.samsung.com> References: <56F0612E.20607@osg.samsung.com> <1458594508-14545-1-git-send-email-bpoirier@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Salam Noureddine To: Benjamin Poirier , netdev@vger.kernel.org Return-path: Received: from lists.s-osg.org ([54.187.51.154]:55414 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753798AbcCUVrm (ORCPT ); Mon, 21 Mar 2016 17:47:42 -0400 In-Reply-To: <1458594508-14545-1-git-send-email-bpoirier@suse.com> Sender: netdev-owner@vger.kernel.org List-ID: On 21/03/16 21:08, Benjamin Poirier wrote: > .//include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_all' > .//include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_specific' > > Introduced by commit 7866a621043f ("dev: add per net_device packet type > chains") > > Cc: Salam Noureddine > Signed-off-by: Benjamin Poirier > --- > include/linux/netdevice.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 9a3d55c..1937bdd 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1418,6 +1418,8 @@ enum netdev_priv_flags { > * @unreg_list: List entry, that is used, when we are unregistering the > * device, see the function unregister_netdev > * @close_list: List entry, that is used, when we are closing the device > + * @ptype_all: Device-specific packet handlers for all protocols > + * @ptype_specific: Device-specific, protocol-specific packet handlers > * > * @adj_list: Directly linked devices, like slaves for bonding > * @all_adj_list: All linked devices, *including* neighbours > Looks good to me. Thanks Benjamin :) Luis